Resolve "Productivity Analytics: Reset MR table page when any of the filters changes"
requested to merge 32546-productivity-analytics-reset-mr-table-page-when-any-of-the-filters-changes into master
What does this MR do?
This MR ensures that we reset pagination on the MR table when any of the global filters (group, project, author, label, milestone, timeframe) on the Productivity Analytics
page changes. Otherwise we might run into problems when the user is still on a page and this page doesn't exist for the updated selection (since we don't have data on that page).
In addition, I've renamed the setMergeRequestsPage
action to setPage
and the related mutation to SET_PAGE
.
This is behind the productivity_analytics
feature flag.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #32546 (closed)
Edited by Martin Wortschack