Skip to content

Add more specs for most_recent_commit_sha method

Marcos Rocharequested to merge
mc_rocha_fix_no_method_error_most_recent_commit_sha_follow_up into master

What does this MR do and why?

This MR adds more specs for most_recent_commit_sha method as suggested in this comment.

In MR !176308 (merged) we added strong_memoize_attr for most_recent_commit_sha because this method can be called more than once. Since we also call last_scan_commit_sha multiple times, this MR also adds strong_memoize_attr for last_scan_commit_sha.

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Marcos Rocha

Merge request reports