add iteration autocomplete to RTE
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you receive complimentary access to GitLab Duo.
What does this MR do and why?
This MR aims to add the iteration feature to the RTE.
References
It aims to fix the issue #407511
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Clone this git repo
- Got to any page that has the RTE
- enter
*iteration:
on the editor, and you should be able to see a list of autocomplete options for iterations
Merge request reports
Activity
added pipelinetier-1 label
Thanks for your contribution to GitLab @salihudickson!
Did you know about our community forks? Working from there will make your contribution process easier. Please check it out!
- If you need help, page a coach by clicking here or come say hi on Discord.
- When you're ready, request a review by clicking here.
- We welcome AI-generated contributions and offer complimentary access to GitLab Duo!
- To add labels to your merge request, comment
@gitlab-bot label ~"label1" ~"label2"
.
This message was generated automatically. Improve it or delete it.
added Community contribution workflowin dev labels
assigned to @salihudickson
added linked-issue label
- Resolved by Himanshu Kapoor
@himkp, this MR is just about ready I'm just having some trouble adding a new feature spec to
spec/support/shared_examples/features/rich_text_editor/autocomplete_shared_examples.rb
. I don't think I have enough hands-on experience with ruby to get this done quickly. A walkthrough would be very much appreciated.
mentioned in issue gitlab-org/quality/triage-reports#21324 (closed)
changed milestone to %Backlog
Thanks for helping us improve the UX of GitLab. Your contribution is appreciated! We have pinged our UX team, so stay tuned for their feedback.
This message was generated automatically. Improve it or delete it.
changed milestone to %17.8
- Resolved by Himanshu Kapoor
@himkp. I was trying out adding iteration. On issues, they are working perfectly. I was thinking, as we are adding support of adding and removing iterations using quick actions on work items, should we also include tagging iterations in work item comments?
- Resolved by Himanshu Kapoor
Hey @nickleonard can you take a look here for UX?
requested review from @nickleonard
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
mentioned in issue #509848 (closed)
Thanks @salihudickson for working on this. LGTM!
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
3 Warnings 6532c2ec: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. 6532c2ec: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @syarynovskyi
(UTC+2)
@zcuddy
(UTC-6)
UX @pedroms
(UTC+0)
Maintainer review is optional for UX Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerrequested review from @himkp
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 5a2420fa and 6532c2ec
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.41 MB 4.41 MB - 0.0 % mainChunk 3.28 MB 3.28 MB - 0.0 %
Note: We do not have exact data for 5a2420fa. So we have used data from: dd526ade.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerE2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 6532c2ecexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 82 | 0 | 8 | 0 | 90 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Govern | 80 | 0 | 12 | 0 | 92 | ✅ | | Create | 135 | 0 | 20 | 0 | 155 | ✅ | | Verify | 48 | 0 | 17 | 0 | 65 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Package | 25 | 0 | 13 | 0 | 38 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Secure | 4 | 0 | 3 | 0 | 7 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 425 | 0 | 120 | 0 | 545 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 6532c2ecexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 140 | 0 | 19 | 1 | 159 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Verify | 49 | 0 | 16 | 0 | 65 | ✅ | | Govern | 84 | 0 | 10 | 0 | 94 | ✅ | | Package | 30 | 0 | 14 | 0 | 44 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 442 | 0 | 119 | 1 | 561 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
started a merge train
mentioned in commit 620e7086
@salihudickson, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Request access to our community forks to receive complimentary access to GitLab Duo, our AI-powered features. With Code Suggestions, Chat, Root Cause Analysis and more AI-powered features, GitLab Duo helps to boost your efficiency and effectiveness by reducing the time required to write and understand code and pipelines. Visit the GitLab Duo documentation to learn more about the benefits.
Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.
Thanks for your help!
This message was generated automatically. Improve it or delete it.
- React with a
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
mentioned in merge request !175981 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label