Cleanup workspaces graphql specs/resolvers
What does this MR do and why?
Several cleanups related to Workspaces graphql resolvers:
- Add missing
Group.workspacesClusterAgents
field, deprecateGroup.remoteDevelopmentClusterAgents
field - Update README under
ee/spec/requests/api/graphql/remote_development
to provide more info and guidance - Add missing specs under
ee/spec/requests/api/graphql/remote_development/cluster_agent/workspaces_agent_config
- Refactor existing specs under
ee/spec/requests/api/graphql/remote_development
to match existing patterns - Change structure of namespaces under
ee/app/graphql/resolvers/remote_development
to more closely match structure of corresponding request specs. - Update and add missing entries to
tests.yml
andscripts/verify-tff-mapping
- Change
ee/app/finders/remote_development/cluster_agents_finder.rb
to return empty array rather than raise error in the case of unauthorized access (to match existing graphql standard patterns). - Other various cleanups
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
- Add agent config type, resolve, finder with per... (!158587 - merged)
- https://gitlab.com/gitlab-org/workspaces/gitlab-workspaces-docs/-/blob/45fdeec0392c6b1d85a9b71d613bd3df2b1de0da/doc/tech-designs/2024-01-23-support-group-agent-authorization.md
Followup issue: Remove clusterAgent.remoteDevelopmentAgentConfi... (#509049 - closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
N/A
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Edited by Chad Woolley