Skip to content

Make commit status created for any pipelines by default

What does this MR do?

This MR contains commits that changes the default behavior of create commit status API. will make commit status stage created through the API to be appended to any type of existing pipeline, instead of just branch pipelines. For example, if there are only merge request pipeline, instead of creating a new branch pipeline, it will append the commit status stage to latest pipeline of any type.

Screenshots

Below are screenshots to illustrate the behavior. Note that the API is hit without any query parameters except state and name, which I set to success and $(date +%s) respectively.

New behavior, before hitting the API: Screenshot_20190907_231330

New behavior, after hitting the API: Screenshot_20190907_231357

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #14064 (closed), #32257 (closed)

Edited by Aufar Gilbran

Merge request reports