Members::ActivityService now checks for membership

Vijay Hawoldarrequested to merge
vij-check-member-exists into master

What does this MR do and why?

This MR ensures the user is a member of the namespace hierarchy before creating a new SeatAssignment record to track their activity, in the GitlabSubscriptions::Members::ActivityService.

This means we won't create unnnecessary records in the subscription_seat_assignments table, as discussed here: https://gitlab.com/gitlab-org/gitlab/-/issues/482392#note_2238492147

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Vijay Hawoldar

Merge request reports