Prevent accidental access level changes when toggling project settings permissions

Shane Maglangitrequested to merge
499879-fix-project-setting-permission-toggles into master

What does this MR do and why?

Key Terms

  • Project Visibility Level: Whether a project is private, public, or internal
  • Project Feature Access Level: Refers to the access levels for individual features such as issues, merge request, and analytics

Changes

This MR prevents the accidental access level change when toggling project features access level.

When a feature toggle is re-enabled, we retain the previously selected dropdown value instead of defaulting to the last option.

Considerations

Unlike before, the "feature access level" for private projects won't be restricted to PROJECT_MEMBERS (10) anymore.

  • This was never truly enforced since creating a new private project sets the feature access levels to EVERYONE (20) by default.
  • It still shouldn't be possible to manually change the private project feature access levels between PROJECT_MEMBER (10) and EVERYONE (20) once this merge request and #508449 (closed) has been merged.

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Notice how in the "before" recording, the access level changed to "Only Project Members" when toggles are re-enabled.

Before

Screen_Recording_2024-12-09_at_12.26.56_PM

After

Screen_Recording_2024-12-09_at_12.24.33_PM

How to set up and validate locally

Initial Setup

  1. Create a new private project.
  2. Go to Settings > General > Visibility, project features, permissions.
  3. Disable and re-enable and enable a project feature (e.g. issues).
    • Expected Behavior: The access level should be retained to the same value. image
Edited by Shane Maglangit

Merge request reports