Skip to content

Add link to Instance Security Dashboard in nav

What does this MR do?

This adds a nav link for the Instance Security Dashboard MVC, which is behind the security_dashboard feature flag. The Instance Security Dashboard is also behind an as-yet undefined read_security_dashboard policy. For the screenshots in this MR where the Security link is visible, both the security_dashboard flag was enabled, and the following patch applied to enable the policy:

allow_read_security_dashboard.patch

A future MR will define the read_security_dashboard policy.

This MR also refactors slightly how the visibility of the Operations and Environments dashboard links is handled. One result of this is that they are now consistently visible/hidden between the dashboards dropdown on larger screens, and the "More" dropdown on smaller screens.

Finally, the partials have been renamed, since they're no longer specific to operations.

Screenshots

State Before After
All enabled, Dashboards dropdown +ops_+envs_dashboard_menu_master +sec_+ops_+envs_dashboardd_menu_branch
All enabled, "More" dropdown +ops_+envs_more_menu_master +sec_+ops_+envs_more_menu_branch
Operations enabled, Environments enabled, Dashboards dropdown +ops_+envs_dashboard_menu_master +ops_+envs_dashboard_menu_branch
Operations enabled, Environments enabled, "More" dropdown +ops_+envs_more_menu_master +ops_+envs_more_menu_branch
Operations enabled, Environments disabled, Dashboards dropdown +ops_-envs_dashboard_menu_master +ops_-envs_dashboard_menu_branch
Operations enabled, Environments disabled, "More" dropdown +ops_-envs_more_menu_master +ops_-envs_more_menu_branch
All disabled, Dashboards dropdown -ops_-envs_dashboard_menu_master -ops_+envs_dashboard_menu_branch
All disabled, "More" dropdown -ops_-envs_more_menu_master Note: Operations link is displayed, which is incorrect, and fixed in this MR -sec_-ops_-envs_more_menu_branch
Only Security enabled, Dashboards dropdown -ops_+envs_dashboard_menu_master +sec_-ops_-envs_dashboard_menu_branch
Only Security enabled, "More" dropdown -ops_-envs_more_menu_master Note: Operations link is displayed, which is incorrect, and fixed in this MR +sec_-ops_-envs_more_menu_branch

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Edited by Mark Florian

Merge request reports