Skip to content

Convert trials lead form to a view component

What does this MR do and why?

Convert trials lead form to a view component

  • first step in converting trial views to ViewComponents
  • better encapsulate logic and when it needs defined, leading to ability to test a bit easier.
  • remove view logic from controller layer and be declarative about when errors are valid.
  • keeps the param sanitation/permitting in the controller layer.
  • covered by unit/integration tests and tests in ee/spec/features/gitlab_subscriptions/trials/creation_with_*
  • see #505668 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

no change

form failed submission
Screenshot_2025-01-13_at_8.29.33_AM Screenshot_2025-01-13_at_8.30.09_AM

How to set up and validate locally

  1. Setup GDK to simulate SaaS.
  2. Create a new group
  3. Visit /-/trials/new.

Related to #505668 (closed)

Edited by Doug Stull

Merge request reports

Loading