Log check result status in mergeability logger
What does this MR do and why?
Prior to this change, mergeability logger only logged the output of the
#success? method. This is not granular enough:
- The status can be
:inactive, which is neither successful nor unsuccessful. So can be false negatives in there. - The combined actually calls
#unsuccessful?and succeeds if no check is unsuccessful. The#unsuccessful?method is implemented asfailed? || checking?. So if the check fails, we don't know if it's intended to be temporary (#checking?) a real failure (#failed?).
We recently ran into this debugging a failed auto merge, where it the approval check appears to have failed, but we can't pin down whether it was due to value from the PostgreSQL or Redis.
With this change, we also log the actual status, so that we can differentiate between different types of successes and failures.
References
Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.