Skip to content
Snippets Groups Projects

Track event when job token is authorized for a project with disabled scope

Merged Erick Bajao requested to merge eb-track-job-token-auth-project-type into master
All threads resolved!

What does this MR do and why?

Addresses item 8 from #478522 (closed):

  1. Unique number of projects receiving authentications while having disabled scope and distinguish between same-project vs cross-project authentications - helps distinguish how many projects use CI_JOB_TOKEN but there is no need to populate the allowlist (same project) vs the cross-project where we need to populate the allowlist. The first numbers will also help calculate the number of projects not impacted at all (inactive or without inbound CI_JOB_TOKEN)

Also updated the module Gitlab::InternalEventsTracking to make track_internal_event usable inside class methods.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Maintainer

    @fabiopitino can you please take a look and let me know if this provides the information that we need?

  • Erick Bajao requested review from @fabiopitino

    requested review from @fabiopitino

  • Erick Bajao requested review from @nbelokolodov

    requested review from @nbelokolodov

  • Erick Bajao added 1 commit

    added 1 commit

    • 46125c54 - Track event when job token is authorized for a project with disabled scope

    Compare with previous version

  • mentioned in issue #478522 (closed)

  • Fabio Pitino approved this merge request

    approved this merge request

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • Fabio Pitino resolved all threads

    resolved all threads

  • Fabio Pitino enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 8cec06a6

    expand test summary
    +--------------------------------------------------------------+
    |                        suites summary                        |
    +---------+--------+--------+---------+-------+-------+--------+
    |         | passed | failed | skipped | flaky | total | result |
    +---------+--------+--------+---------+-------+-------+--------+
    | Verify  | 38     | 0      | 1       | 0     | 39    | ✅     |
    | Package | 25     | 0      | 0       | 0     | 25    | ✅     |
    | Govern  | 17     | 0      | 0       | 0     | 17    | ✅     |
    | Plan    | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Create  | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Secure  | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Release | 3      | 0      | 0       | 0     | 3     | ✅     |
    +---------+--------+--------+---------+-------+-------+--------+
    | Total   | 95     | 0      | 1       | 0     | 96    | ✅     |
    +---------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-cng: :white_check_mark: test report for 8cec06a6

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
    | Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
    | Analytics   | 2      | 0      | 0       | 1     | 2     | ✅     |
    | Fulfillment | 2      | 0      | 7       | 1     | 9     | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Create      | 140    | 0      | 20      | 0     | 160   | ✅     |
    | Verify      | 49     | 0      | 16      | 0     | 65    | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Govern      | 84     | 0      | 9       | 1     | 93    | ✅     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 436    | 0      | 119     | 3     | 555   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Erick Bajao aborted automatic add to merge train because the source branch was updated. Learn more.

    aborted automatic add to merge train because the source branch was updated. Learn more.

  • Erick Bajao added 1 commit

    added 1 commit

    • 47241569 - Use extend to use tracking in class methods

    Compare with previous version

  • Erick Bajao reset approvals from @fabiopitino by pushing to the branch

    reset approvals from @fabiopitino by pushing to the branch

  • Ghost User
  • Erick Bajao added 832 commits

    added 832 commits

    • 47241569...a8c2c9f2 - 829 commits from branch master
    • 59e4dbc4 - Track event when job token is authorized for a project with disabled scope
    • ba0003df - Use extend to use tracking in class methods
    • 8cec06a6 - Clean up tracking calls

    Compare with previous version

  • Niko Belokolodov approved this merge request

    approved this merge request

  • Niko Belokolodov removed review request for @nbelokolodov

    removed review request for @nbelokolodov

  • Erick Bajao requested review from @fabiopitino

    requested review from @fabiopitino

  • Fabio Pitino approved this merge request

    approved this merge request

  • Fabio Pitino resolved all threads

    resolved all threads

  • Fabio Pitino enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • merged

  • Fabio Pitino mentioned in commit c6d4a466

    mentioned in commit c6d4a466

  • Hello @iamricecake :wave:

    The Analytics Instrumentation team is actively working on improving the metrics implementation and event tracking processes. We would love to hear about your experience and any feedback you might have!

    To provide your feedback, please use this Google Form.

    Thanks for your help! :heart:


    This message was generated automatically. Improve it or delete it.

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading