Skip to content

Fix 401 errors when installing the GitLab for Jira app

What does this MR do and why?

We assumed that the key ID to fetch public keys from the Atlassian CDN must be a UUID but the pattern seems to have changed. This MR changes the validation to allow strings other than valid UUIDs. This leads to 401 errors when installing the GitLab for Jira app.

The related RFC doesn't specify the kid format either.

References

Please include cross links to any resources that are relevant to this MR. This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Follow the guide to set up a development environment for the GitLab for Jira app using Gitpod: https://docs.gitlab.com/ee/development/integrations/jira_connect.html#install-the-app-in-jira

Edited by Andy Schoenen

Merge request reports

Loading