Skip to content
Snippets Groups Projects

Mini Pipeline graph: Fix max height

Merged Sascha Eggenberger requested to merge mini-pipeline-graph-max-height-fix into master
All threads resolved!

What does this MR do and why?

Mini Pipeline graph: Fixes the max height of the dropdowns

This seems to be a regression of the recent dropdown migration efforts in #384853 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
before after
before2 after2

How to set up and validate locally

  1. Go to a MR or any pipeline related page where we show a mini pipeline graph
  2. Check the max-height of the dropdown

Related to #499695 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits ee3b1a91 and 1f741a06

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.46 MB 4.46 MB - 0.0 %
    mainChunk 3.36 MB 3.36 MB - 0.0 %

    Note: We do not have exact data for ee3b1a91. So we have used data from: c21fcd60.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Briley Sandlin approved this merge request

    approved this merge request

  • Briley Sandlin removed review request for @bsandlin

    removed review request for @bsandlin

  • requested review from @mrincon

  • Sascha Eggenberger added 317 commits

    added 317 commits

    Compare with previous version

  • Sascha Eggenberger reset approvals from @bsandlin by pushing to the branch

    reset approvals from @bsandlin by pushing to the branch

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 1f741a06

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 76     | 0      | 0       | 0     | 76    | ✅     |
    | Package     | 24     | 0      | 11      | 0     | 35    | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Create      | 129    | 0      | 22      | 0     | 151   | ✅     |
    | Verify      | 43     | 0      | 2       | 0     | 45    | ✅     |
    | Govern      | 75     | 0      | 3       | 0     | 78    | ✅     |
    | Data Stores | 33     | 0      | 1       | 0     | 34    | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
    | Secure      | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Ai-powered  | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 402    | 0      | 41      | 0     | 443   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-cng: :white_check_mark: test report for 1f741a06

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Verify      | 49     | 0      | 16      | 0     | 65    | ✅     |
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
    | Create      | 140    | 0      | 20      | 0     | 160   | ✅     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Fulfillment | 2      | 0      | 7       | 1     | 9     | ✅     |
    | Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
    | Govern      | 84     | 0      | 9       | 1     | 93    | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Analytics   | 2      | 0      | 0       | 1     | 2     | ✅     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 436    | 0      | 119     | 3     | 555   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • mentioned in issue gitlab-ui#3010

  • added 1 commit

    • 1f741a06 - Mini Pipeline graph: Fix max height

    Compare with previous version

  • Miguel Rincon approved this merge request

    approved this merge request

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • Miguel Rincon resolved all threads

    resolved all threads

  • Miguel Rincon enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Miguel Rincon mentioned in commit a88ea7ef

    mentioned in commit a88ea7ef

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading