Skip to content

Call RenameRepository and RemoveRepository

John Cai requested to merge jc-refactor-mv-repository into master

What does this MR do?

Refactor shell.rb to call RenameRepository and RemoveRepository. We are trying to get rid of all calls to the NamespaceService.

Since shell.rb calls RenameRepository, which also does a mkdir -p before it moves the repository, we can also get rid of some calls to add_namespace in ee/app/services/geo/repository_base_sync_service.rb

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by John Cai

Merge request reports