Display bolder warning if email TLD is missing

• Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you can request access to GitLab Duo.

What does this MR do and why?

In the registration page, display a warning, This email address does not look right, are you sure you typed it correctly?, in red color when the email address doesn't have a valid top-level-domain (TLD):

• missing a@b, or
• less than two characters a@b.c

The form can be submitted with the warning.

No changes in the rest of other invalid emails:

Invalid email	Same behaviour before and after	Reason
"A"@b.co	Please provide a valid email address	quoted emails
ab.co	Please provide a valid email address	no @ symbol
a@b@c.co	Please provide a valid email address	several @ symbol
a@-b.co	Please provide a valid email address	domain starting with hyphen
a@b-.co	Please provide a valid email address	domain finishing with hyphen
a@example_me.co	Please provide a valid email address	domain with underscore
a@[123.123.123.123]	Please provide a valid email address	IP addresses

Closes #499244 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before	After

How to set up and validate locally

1. Go to either:

• /users/sign_up or
• /-/trial_registrations/new (SAAS enabled)

1. Check the email field in the registration

Related to #499244 (closed)

added devopssoftware supply chain security groupauthentication sectionsec typebug labels

added pipelinetier-1 label

assigned to @eduardosanz

assigned to @divyamtayal

added backend frontend labels

Reviewer roulette

Category	Reviewer	Maintainer
backend	@tigerwnz (UTC+13, 12 hours ahead of author)	@sdungarwal (UTC+5.5, 4.5 hours ahead of author)
frontend	@thomasrandolph (UTC-7, 8 hours behind author)	@mlunoe (UTC+1, same timezone as author)
test for spec/features/*	@tigerwnz (UTC+13, 12 hours ahead of author)	Maintainer review is optional for test for spec/features/*
groupauthentication	Reviewer review is optional for groupauthentication	@sgarg_gitlab (UTC+5.5, 4.5 hours ahead of author)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits f0c13cbf and c9bf661a

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.47 MB	4.47 MB	-	0.0 %
mainChunk	3.36 MB	3.36 MB	-	0.0 %

---

Note: We do not have exact data for f0c13cbf. So we have used data from: a2ff1112.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

changed milestone to %17.6

changed the description

mentioned in issue #499244 (closed)

mentioned in merge request !169617 (closed)

changed the description

@fernando-c and @sgarg_gitlab, please, could you review this when you have time? Thanks!

requested review from @fernando-c and @sgarg_gitlab

approved this merge request

added pipeline:mr-approved label

added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

Before you set this MR to auto-merge, please check the following:

• You are the last maintainer of this merge request
• The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
• This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.

added backend frontend labels

Generated by gitlab_quality-test_tooling.

---

Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

Click to expand

Job	File	Name	Duration	Expected duration
#8411509719	spec/features/admin/users/users_spec.rb#L177	Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking	66.68 s	< 50.13 s
#8411509413	spec/lib/release_highlights/validator_spec.rb#L82	ReleaseHighlights::Validator when validating all files they should have no errors	80.82 s	< 27.12 s
#8427909348	spec/lib/release_highlights/validator_spec.rb#L82	ReleaseHighlights::Validator when validating all files they should have no errors	75.13 s	< 27.12 s
#8427909456	spec/features/admin/users/users_spec.rb#L177	Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking	66.34 s	< 50.13 s
#8470032310	spec/lib/release_highlights/validator_spec.rb#L82	ReleaseHighlights::Validator when validating all files they should have no errors	80.44 s	< 27.12 s
#8470032502	spec/features/admin/users/users_spec.rb#L177	Admin::Users GET /admin/users when blocking/unblocking a user shows confirmation and allows blocking and unblocking	65.79 s	< 50.13 s

added rspec:slow test detected label

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for c9bf661a

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Plan        | 76     | 0      | 0       | 0     | 76    | ✅     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
| Create      | 129    | 0      | 22      | 0     | 151   | ✅     |
| Govern      | 75     | 0      | 3       | 0     | 78    | ✅     |
| Data Stores | 33     | 0      | 1       | 0     | 34    | ✅     |
| Verify      | 43     | 0      | 2       | 0     | 45    | ✅     |
| Package     | 25     | 0      | 11      | 0     | 36    | ✅     |
| Secure      | 4      | 0      | 0       | 0     | 4     | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Ai-powered  | 0      | 0      | 1       | 0     | 1     | ➖     |
| Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
| Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
| Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 403    | 0      | 41      | 0     | 444   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-test-on-cng: test report for c9bf661a

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
| Create      | 140    | 0      | 20      | 0     | 160   | ✅     |
| Govern      | 84     | 0      | 9       | 0     | 93    | ✅     |
| Verify      | 49     | 0      | 16      | 0     | 65    | ✅     |
| Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
| Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
| Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
| ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
| Fulfillment | 2      | 0      | 7       | 0     | 9     | ✅     |
| Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
| Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
| Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
| Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
| Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 436    | 0      | 119     | 0     | 555   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

changed milestone to %17.7

added missed:17.6 label

added 1 commit

• 3f47d9aa - Apply simplification of regex

Compare with previous version

reset approvals from @sgarg_gitlab by pushing to the branch

added 1 commit

• c9bf661a - Code simplification and more specific warning

Compare with previous version

requested review from @sgarg_gitlab

approved this merge request

approved this merge request

resolved all threads

added Category:System Access label

enabled automatic add to merge train when checks pass

added this merge request to the merge train at position 2

merged

mentioned in commit e452b894

added workflowstaging-canary label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added workflowpost-deploy-db-staging label and removed workflowproduction label

added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label