Update error handling of subscription

changed milestone to %17.6

added Category:Security Policy Management Stretch backend devopssecurity risk management frontend groupsecurity policies maintenancerefactor missed:17.5 sectionsec typemaintenance workflowin review labels

assigned to @aturinske

added pipelinetier-1 label

changed the description

removed pipelinetier-1 label

@Andyschoenen I am confused a bit by the backend still. In the scenario listed in the description, I thought the backend was going to throw an error if the subscription failed due to a backend issue (e.g. a security policy project already exists with the name, but isn't linked), returning the standard graphql error, which would be then picked up the apollo graphql error catcher.

But the errors still get put into a successful request, is that correct?

example of error responses by graphql below.

{ errors: [{message, locations, extensions}] }

Response by the subscription is still a successful response

{
  data: {
     securityPolicyProjectCreated: {
       status: 'FAILED',
       errors: [...],
       errorMessage: '...',
       project: { ... },
     },
  },
}

mentioned in merge request !172751 (closed)

added 556 commits

51a570a7...24811360 - 555 commits from branch master
bb70b73c - Update error handling of subscription

Compare with previous version

changed the description

Reviewer roulette

Category	Reviewer	Maintainer
frontend	`@ramistry` (UTC+5.5, 13.5 hours ahead of author)	`@jivanvl` (UTC-6, 2 hours ahead of author)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

resolved all threads

added 1 commit

0a8452cc - Update error handling of subscription

Compare with previous version

@snachnolkar can you review this? Thanks

requested review from @snachnolkar

changed milestone to %17.7

marked this merge request as ready

approved this merge request

added pipeline:mr-approved label

added pipelinetier-2 label

requested review from @mfluharty and removed review request for @snachnolkar

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 11a02dd5 and 09030197

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.46 MB	4.46 MB	-	-0.0 %
mainChunk	3.36 MB	3.36 MB	-	0.0 %

Note: We do not have exact data for 11a02dd5. So we have used data from: 3abf3154.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

Before you set this MR to auto-merge

This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

Before you set this MR to auto-merge, please check the following:

You are the last maintainer of this merge request
The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
This pipeline is recent enough (created in the last 8 hours)

If all the criteria above apply, please set auto-merge for this merge request.

See pipeline tiers and merging a merge request for more details.

nitpick (non-blocking): This "The file path can't be empty" form validation message doesn't seem to be true

Screen_Recording_2024-11-19_at_12.59.34

mentioned in issue #505363 (closed)

enabled automatic add to merge train when checks pass

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 09030197

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 129    | 0      | 22      | 0     | 151   | ✅     |
| Govern      | 75     | 0      | 3       | 0     | 78    | ✅     |
| Package     | 24     | 0      | 11      | 0     | 35    | ✅     |
| Verify      | 43     | 0      | 2       | 0     | 45    | ✅     |
| Plan        | 76     | 0      | 0       | 0     | 76    | ✅     |
| Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
| Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
| Data Stores | 33     | 0      | 1       | 0     | 34    | ✅     |
| Secure      | 4      | 0      | 0       | 0     | 4     | ✅     |
| Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Ai-powered  | 0      | 0      | 1       | 0     | 1     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 402    | 0      | 41      | 0     | 443   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-test-on-cng: test report for 09030197

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 140    | 0      | 20      | 0     | 160   | ✅     |
| Verify      | 49     | 0      | 16      | 0     | 65    | ✅     |
| Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
| Analytics   | 2      | 0      | 0       | 1     | 2     | ✅     |
| Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
| Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
| Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
| Govern      | 84     | 0      | 9       | 1     | 93    | ✅     |
| Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
| Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
| Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
| Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
| Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
| Fulfillment | 2      | 0      | 7       | 1     | 9     | ✅     |
| Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
| ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 436    | 0      | 119     | 3     | 555   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+