Fix logic and styling of archived project warning in diff comments
What does this MR do and why?
Fix logic and styling of archived project warning in diff comments
- When project is archived, don't show signed in users the "please sign in" prompt, show them the archived project prompt
- When a project cannot be commented on and there are no replies, do not show the empty reply holder in threaded comments; it is wasted empty vertical space
References
Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
Screenshots or screen recordings
Note that these screenshots apply only to comments in archived projects
MR diff comments:
Before | After |
---|---|
![]() |
![]() |
MR regular comments:
Before | After |
---|---|
![]() |
![]() |
Issue comments:
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Ensure you have an MR somewhere in the GDK that has comments on a diff. Some but not all of the comments should have replies.
- In a separate tab, archive the project that contains that MR (don't worry, this is reversible)
- In the tab where the MR diff with comments is, refresh the page to see the changes from this MR
Related to #504137 (closed)
Merge request reports
Activity
changed milestone to %17.7
assigned to @clavimoniere
added pipelinetier-1 label
- A deleted user
added frontend label
Reviewer roulette
Category Reviewer Maintainer frontend @fernanda.toledo
(UTC-8, 3 hours behind author)
@arfedoro
(UTC+1, 6 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits f3f21d6a and 191d9a46
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.42 MB 4.42 MB - 0.0 % mainChunk 3.31 MB 3.31 MB - 0.0 %
Note: We do not have exact data for f3f21d6a. So we have used data from: 5f5294fb.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 1 commit
- e9867cb1 - Fix logic and styling of archived project warning in diff comments
- Resolved by Chad Lavimoniere
@seggenberger can you give this a UX Paper Cuts review?
requested review from @seggenberger
- Resolved by Chad Lavimoniere
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 191d9a46expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Create | 129 | 0 | 22 | 0 | 151 | ✅ | | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 24 | 0 | 11 | 0 | 35 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 75 | 0 | 3 | 0 | 78 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 402 | 0 | 41 | 0 | 443 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 191d9a46expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 84 | 0 | 9 | 1 | 93 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Create | 140 | 0 | 20 | 0 | 160 | ✅ | | Verify | 49 | 0 | 16 | 0 | 65 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Fulfillment | 2 | 0 | 7 | 1 | 9 | ✅ | | Analytics | 2 | 0 | 0 | 1 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 436 | 0 | 119 | 3 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
added 638 commits
-
e9867cb1...d4d99c9c - 637 commits from branch
master
- 191d9a46 - Fix logic and styling of archived project warning in diff comments
-
e9867cb1...d4d99c9c - 637 commits from branch
- Resolved by Artur Fedorov
@xanf could you also maintainerize this one
requested review from @xanf
requested review from @xanf
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
started a merge train
mentioned in commit ab6474d1
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label