Fix logic and styling of archived project warning in diff comments

Chad Lavimoniererequested to merge
504137-comment-threads-in-mr-changes-tab-show-register-sign-in-prompt-to-logged-in-users-if-project into master

What does this MR do and why?

Fix logic and styling of archived project warning in diff comments

  • When project is archived, don't show signed in users the "please sign in" prompt, show them the archived project prompt
  • When a project cannot be commented on and there are no replies, do not show the empty reply holder in threaded comments; it is wasted empty vertical space

References

Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

Screenshots or screen recordings

Note that these screenshots apply only to comments in archived projects

MR diff comments:

Before After
e0a61267879f46657081daca0965c26d fdc132532ee8796522e283a5340853de

MR regular comments:

Before After
4e87105bf8fd7ab3c83711e74ce2d237 e6dbb231436cac1b634132753d94b3ef

Issue comments:

Before After
Screenshot_2024-11-15_at_19.16.24 Screenshot_2024-11-15_at_19.16.43

How to set up and validate locally

  1. Ensure you have an MR somewhere in the GDK that has comments on a diff. Some but not all of the comments should have replies.
  2. In a separate tab, archive the project that contains that MR (don't worry, this is reversible)
  3. In the tab where the MR diff with comments is, refresh the page to see the changes from this MR

Related to #504137 (closed)

Edited by Chad Lavimoniere

Merge request reports