Skip to content
Snippets Groups Projects

Fix logic and styling of archived project warning in diff comments

All threads resolved!

What does this MR do and why?

Fix logic and styling of archived project warning in diff comments

  • When project is archived, don't show signed in users the "please sign in" prompt, show them the archived project prompt
  • When a project cannot be commented on and there are no replies, do not show the empty reply holder in threaded comments; it is wasted empty vertical space

References

Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

Screenshots or screen recordings

Note that these screenshots apply only to comments in archived projects

MR diff comments:

Before After
e0a61267879f46657081daca0965c26d fdc132532ee8796522e283a5340853de

MR regular comments:

Before After
4e87105bf8fd7ab3c83711e74ce2d237 e6dbb231436cac1b634132753d94b3ef

Issue comments:

Before After
Screenshot_2024-11-15_at_19.16.24 Screenshot_2024-11-15_at_19.16.43

How to set up and validate locally

  1. Ensure you have an MR somewhere in the GDK that has comments on a diff. Some but not all of the comments should have replies.
  2. In a separate tab, archive the project that contains that MR (don't worry, this is reversible)
  3. In the tab where the MR diff with comments is, refresh the page to see the changes from this MR

Related to #504137 (closed)

Edited by Chad Lavimoniere

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sascha Eggenberger approved this merge request

    approved this merge request

  • added pipelinetier-2 label and removed pipelinetier-1 label

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 191d9a46

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Verify      | 43     | 0      | 2       | 0     | 45    | ✅     |
    | Create      | 129    | 0      | 22      | 0     | 151   | ✅     |
    | Plan        | 76     | 0      | 0       | 0     | 76    | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Package     | 24     | 0      | 11      | 0     | 35    | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Data Stores | 33     | 0      | 1       | 0     | 34    | ✅     |
    | Secure      | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Govern      | 75     | 0      | 3       | 0     | 78    | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
    | Ai-powered  | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 402    | 0      | 41      | 0     | 443   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-cng: :white_check_mark: test report for 191d9a46

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Govern      | 84     | 0      | 9       | 1     | 93    | ✅     |
    | Plan        | 86     | 0      | 8       | 0     | 94    | ✅     |
    | Data Stores | 33     | 0      | 10      | 0     | 43    | ✅     |
    | Create      | 140    | 0      | 20      | 0     | 160   | ✅     |
    | Verify      | 49     | 0      | 16      | 0     | 65    | ✅     |
    | Package     | 24     | 0      | 14      | 0     | 38    | ✅     |
    | Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Manage      | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Monitor     | 8      | 0      | 12      | 0     | 20    | ✅     |
    | Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
    | ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Ai-powered  | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Secure      | 2      | 0      | 5       | 0     | 7     | ✅     |
    | Fulfillment | 2      | 0      | 7       | 1     | 9     | ✅     |
    | Analytics   | 2      | 0      | 0       | 1     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 436    | 0      | 119     | 3     | 555   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Chad Lavimoniere added 638 commits

    added 638 commits

    Compare with previous version

  • Chad Lavimoniere marked this merge request as ready

    marked this merge request as ready

  • Chad Lavimoniere requested review from @xanf

    requested review from @xanf

  • Chad Lavimoniere resolved all threads

    resolved all threads

  • @arfedoro can you do a frontend maintainer review on this?

  • Chad Lavimoniere requested review from @arfedoro and removed review request for @xanf

    requested review from @arfedoro and removed review request for @xanf

  • Illya Klymov approved this merge request

    approved this merge request

  • Illya Klymov requested review from @xanf

    requested review from @xanf

  • Illya Klymov enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Illya Klymov resolved all threads

    resolved all threads

  • Artur Fedorov removed review request for @xanf and @arfedoro

    removed review request for @xanf and @arfedoro

  • merged

  • Illya Klymov mentioned in commit ab6474d1

    mentioned in commit ab6474d1

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading