Allow for search in dropdown
What does this MR do and why?
Allow for search in dropdown
- allow users to search for groups outside of first page
- populate dropdown with existing ids if they are not retrieved in the first page
- policy drawer will need a similar change, but that will come in another MR
- if a user updates the yaml and navigates back to rule mode, we need to request any added ids that have not been retrieved already
- refactor to move this logic into the utils
- update tests
References
Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
| No search and if the selected ids where not on the first page, they were not selected | searchable_groups_small update_search_small |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Upload a GitLab Ultimate license
- Enable the feature flag
echo "Feature.enable(:scan_result_policy_block_group_branch_modification)" | rails c - Navigate to a group => Secure => Policies => New policy => Merge request approval policy
- Verify the
Block group branch modificationgroup selection is search able - Navigate to yaml mode and modify the ids
- Navigate to rule mode and ensure the new ids are selected
Related to #500842 (closed)
Edited by Alexander Turinske