Ci::BuildTraceChunks - Add desired sharding key
What does this MR do and why?
Add desired sharding key to Ci::BuildTraceChunks using existing automation
- already had association that could reference sharding key
- Check of production db shows no records with null
build_id
https://console.postgres.ai/gitlab/gitlab-production-ci/sessions/33179/commands/102508
References
Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Related to #458479 (closed)
Merge request reports
Activity
changed milestone to %17.7
assigned to @vwolanyk
added pipelinetier-1 label
- A deleted user
added database databasereview pending labels
1 Message This merge request adds or changes files that require a review from the Database team. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
The following files require a review from the Database team:
db/docs/ci_build_trace_chunks.yml
Reviewer roulette
Category Reviewer Maintainer database @j.seto
(UTC-5, same timezone as author)
@Andyschoenen
(UTC+1, 6 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue #458479 (closed)
- Resolved by Adam Hegyi
@ahegyi could you please review this MR and once done hand it off to @tianwenchen
requested review from @ahegyi
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
added pipelinetier-1 label and removed pipelinetier-3 pipeline:run-e2e-omnibus-once labels
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
added databasereviewed label and removed databasereview pending label
added databaseapproved label and removed databasereviewed label
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for bcc68407expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 45 | 0 | 2 | 0 | 47 | ✅ | | Govern | 75 | 0 | 3 | 1 | 78 | ✅ | | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Package | 17 | 0 | 18 | 0 | 35 | ✅ | | Create | 129 | 0 | 22 | 0 | 151 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 397 | 0 | 48 | 1 | 445 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for bcc68407expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 50 | 0 | 15 | 2 | 65 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Create | 139 | 0 | 21 | 2 | 160 | ✅ | | Govern | 84 | 0 | 9 | 10 | 93 | ✅ | | Secure | 1 | 0 | 6 | 0 | 7 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 435 | 0 | 120 | 14 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
mentioned in merge request !171427 (merged)
changed milestone to %17.6
started a merge train
mentioned in commit 5b2b7cd5
Hello @vwolanyk
The database team is looking for ways to improve the database review process and we would love your help!
If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:
@gitlab-org/database-team
And someone will be by shortly!
Thanks for your help!
This message was generated automatically. Improve it or delete it.
added workflowissue reviewed label and removed workflowin dev label
added workflowstaging-canary label and removed workflowissue reviewed label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label