Avoid updating or creating runner managers when deleting runner

Pedro Pombeirorequested to merge
pedropombeiro/502431/avoid-creating-runner-managers into master

What does this MR do and why?

This MR fixes the application logic so that we avoid updating or creating a runner manager when we know we're deleting its runner (which will cause the associated runner managers to be deleted anyway). This would have avoided some DELETE /runners requests failing during the recent gitlab-com/gl-infra/production#18792 (closed) incident.

Changelog: fixed

References

Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

n/a

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Run the tests while disabling one or the other boolean arguments.

Edited by Pedro Pombeiro

Merge request reports