Update vertical spacing of project settings
What does this MR do and why?
- Updates vertical spacing of project settings (reported in Slack)
- Aligns toggle to top of container when it's next to a
select
so there is even spacing between every toggle setting + label/description - Indents
Enable CVE ID requests...
underIssues
. None of the behavior has changed (ie it won't be automatically deselected/disabled if you deselect the firstIssues
toggle item, but I think this makes sense
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
Project > settings > general > expand Visibility, project features, permissions
Links
Merge request reports
Activity
changed milestone to %17.6
added UX UX Paper Cuts frontend maintenanceusability typemaintenance labels
assigned to @annabeldunstone
added pipelinetier-1 label
- Resolved by Lorenz van Herwaarden
@nickleonard I've made a small change with the
Issues
setting here, outlined in the description. Could you please take a look?There isn't any functional change but maybe we should open a follow-up if there should be
requested review from @nickleonard
Reviewer roulette
Category Reviewer Maintainer frontend @rhardarson
(UTC+1, 1 hour ahead of author)
@lorenzvanherwaarden
(UTC+1, 1 hour ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Lorenz van Herwaarden
@clavimoniere Could you please review UX here?
requested review from @clavimoniere
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 7d6d296c and 634e5d51
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.4 MB 4.4 MB - 0.0 % mainChunk 3.31 MB 3.31 MB - 0.0 %
Note: We do not have exact data for 7d6d296c. So we have used data from: 9400fb99.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 634e5d51expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 129 | 0 | 22 | 0 | 151 | ✅ | | Govern | 75 | 0 | 3 | 0 | 78 | ✅ | | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Package | 17 | 0 | 18 | 0 | 35 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 396 | 0 | 48 | 0 | 444 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 634e5d51expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 50 | 0 | 15 | 0 | 65 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Govern | 84 | 0 | 9 | 3 | 93 | ✅ | | Create | 139 | 0 | 21 | 0 | 160 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Secure | 1 | 0 | 6 | 0 | 7 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 435 | 0 | 120 | 3 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Annabel Dunstone Gray
- Resolved by Chad Lavimoniere
requested review from @clavimoniere
requested review from @ccharnolevsky
added 664 commits
-
50e53b4a...1f491b88 - 663 commits from branch
master
- 747665f3 - Update vertical spacing of project settings
-
50e53b4a...1f491b88 - 663 commits from branch
added 206 commits
-
747665f3...b291dac4 - 205 commits from branch
master
- 634e5d51 - Update vertical spacing of project settings
-
747665f3...b291dac4 - 205 commits from branch
requested review from @lorenzvanherwaarden
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
started a merge train
mentioned in commit 5cdb2de5
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label