Add feature flag to skip sidebar counts
What does this MR do and why?
We are working on moving these counts to a separate request. When this feature flag is enabled, the backend will not compute the counts and in another MR we will add logic for the frontend to fetch the counts from GraphQL
References
Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
How to set up and validate locally
- Enable
async_sidebar_counts
feature flag - You should no longer see issue, MR, and epic counts in the project and group sidebar
Merge request reports
Activity
changed milestone to %17.6
assigned to @engwan
added pipelinetier-1 label
removed database label
removed Category:Database label
- A deleted user
added feature flag label
- Resolved by Heinrich Lee Yu
1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @micthomas
(UTC-5, 13 hours behind author)
@vyaklushin
(UTC+1, 7 hours behind author)
test for spec/features/*
@micthomas
(UTC-5, 13 hours behind author)
Maintainer review is optional for test for spec/features/*
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger@fernanda.toledo @donaldcook I opened this MR to add the feature flag for the async sidebar counts.
Getting this merged / deployed would actually solve the customer's issue even if the frontend is not merged yet since we can enable this for their group. They just wouldn't see any counts until the FE work is complete.
@fernanda.toledo for the FE MR, you just need to do a
push_frontend_feature_flag
call inProjects::ApplicationController
andGroups::ApplicationController
. Just let me know if you need some help with that.- Resolved by Halil Coban
@kassio can you do the backend review of this MR since you reviewed the other one?
requested review from @kassio
- Resolved by Halil Coban
- Resolved by Halil Coban
requested review from @halilcoban
added pipeline:mr-approved label
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 4ac18339expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 258 | 0 | 38 | 0 | 296 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Plan | 152 | 0 | 0 | 0 | 152 | ✅ | | Data Stores | 66 | 0 | 2 | 0 | 68 | ✅ | | Verify | 90 | 0 | 4 | 0 | 94 | ✅ | | Manage | 2 | 0 | 2 | 0 | 4 | ✅ | | Govern | 150 | 0 | 6 | 2 | 156 | ✅ | | Package | 34 | 0 | 36 | 0 | 70 | ✅ | | Monitor | 16 | 0 | 0 | 0 | 16 | ✅ | | Release | 10 | 0 | 0 | 0 | 10 | ✅ | | Fulfillment | 4 | 0 | 0 | 0 | 4 | ✅ | | Secure | 8 | 0 | 0 | 0 | 8 | ✅ | | Analytics | 4 | 0 | 0 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 794 | 0 | 90 | 2 | 884 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 4ac18339expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 50 | 0 | 15 | 10 | 65 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Govern | 84 | 0 | 9 | 11 | 93 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Create | 139 | 0 | 21 | 12 | 160 | ✅ | | Plan | 86 | 0 | 8 | 7 | 94 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Secure | 1 | 0 | 6 | 0 | 7 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 435 | 0 | 120 | 40 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
added 84 commits
-
072101f1...d27a01d1 - 82 commits from branch
master
- dd69a827 - Add feature flag to skip sidebar counts
- 4ac18339 - Disable feature flag in feature specs
-
072101f1...d27a01d1 - 82 commits from branch
reset approvals from @kassio by pushing to the branch
- Resolved by Halil Coban
added this merge request to the merge train at position 2
mentioned in commit df984b74
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#9241 (closed)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label