Skip to content

Use `deleted_at` column to mark groups in deletion process

Abdul Wadood requested to merge 501158-use-group-deleted-at into master

What does this MR do and why?

The current 'pending_delete' column name is misleading. It suggests future deletion but actually indicates an ongoing deletion process. The new column name better reflects the actual state of the group and avoids confusion about the deletion status.

Here we don't need to backfill this column because the only finder using the current column i.e. Organizations::GroupsFinder is experimental.

Query plans

Before: https://console.postgres.ai/gitlab/gitlab-production-main/sessions/29629/commands/91974

After: https://console.postgres.ai/gitlab/gitlab-production-main/sessions/33105/commands/102254

References

#501158

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

You can follow these steps:

  1. How to set up and validate locally
  2. How to set up and validate locally

Related to #501158

Edited by Abdul Wadood

Merge request reports

Loading