[backport] Add epic to the scope and fix the flaky spec
What does this MR do and why?
Backport !170270 (merged) to %17.5
This MR fixes group search for epics and work items (issues)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch. -
The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes). -
This MR has a severity label assigned (if applicable). -
Set the milestone of the merge request to match the target backport branch version. -
This MR has been approved by a maintainer (only one approval is required). -
Ensure the e2e:test-on-omnibus-ee
job has either succeeded or been approved by a Software Engineer in Test.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releases
Slack channel (internal only).
Merge request reports
Activity
assigned to @terrichu
changed milestone to %17.5
added groupglobal search typebug labels
added devopsdata stores sectioncore platform labels
added pipelinetier-1 label
@sdungarwal would you mind a maintainer review/merge for this backport?
I did not port everything over because there was a spec change in
ee/spec/lib/gitlab/elastic/group_search_results_spec.rb
that was pretty different from %17.5. Can you take a look and make sure it's ok?requested review from @sdungarwal
- A deleted user
added backend label
1 Warning The e2e:test-on-omnibus-ee
job needs to succeed or have approval from a Software Engineer in Test.
Read the "QA e2e:test-on-omnibus-ee" section for more details.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @SamWord
(UTC-4, same timezone as author)
@igor.drozdov
(UTC+1, 5 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
QA
e2e:test-on-omnibus-ee
@terrichu, the
e2e:test-on-omnibus
job must complete before merging this merge request.*If there are failures on the
e2e:test-on-omnibus
pipeline, ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the#test-platform
Slack channel.If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in incident gitlab-org/release/tasks#13828 (closed)
Generated bygitlab_quality-test_tooling
.
Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #8206643349 ee/spec/features/search/elastic/group_search_spec.rb#L134
Group elastic search redactions when we have document_type as work_item behaves like a redacted search results page behaves like redacted search results page assertions when logged in redacts private features the user does not have access to 50.36 s < 50.13 s #8212500245 ee/spec/features/search/elastic/group_search_spec.rb#L48
Group elastic search when searching for all scopes except issues and epics finds all the scopes 51.72 s < 50.13 s - A deleted user
added rspec:slow test detected label
- Resolved by Siddharth Dungarwal
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-omnibus:
test report for f34bf193expand test summary
+---------------------------------------------------------------------+ | suites summary | +----------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------+--------+--------+---------+-------+-------+--------+ | Plan | 56 | 0 | 7 | 0 | 63 | ✅ | | Manage | 26 | 0 | 12 | 5 | 38 | ✅ | | Govern | 90 | 0 | 4 | 0 | 94 | ✅ | | Package | 29 | 0 | 13 | 0 | 42 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Verify | 42 | 0 | 13 | 0 | 55 | ✅ | | Create | 529 | 7 | 72 | 7 | 608 | ❌ | | Systems | 6 | 0 | 1 | 0 | 7 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Fulfillment | 4 | 0 | 7 | 0 | 11 | ✅ | | Secure | 5 | 0 | 2 | 1 | 7 | ✅ | | Data Stores | 39 | 0 | 7 | 0 | 46 | ✅ | | Analytics | 3 | 0 | 0 | 0 | 3 | ✅ | | Configure | 1 | 0 | 2 | 0 | 3 | ✅ | | Ai-powered | 0 | 1 | 2 | 1 | 3 | ❌ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +----------------+--------+--------+---------+-------+-------+--------+ | Total | 845 | 8 | 157 | 14 | 1010 | ❌ | +----------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-gdk:
test report for f34bf193expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Create | 128 | 0 | 18 | 0 | 146 | ✅ | | Govern | 71 | 0 | 2 | 0 | 73 | ✅ | | Package | 17 | 0 | 18 | 0 | 35 | ✅ | | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Verify | 45 | 0 | 2 | 0 | 47 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 392 | 0 | 42 | 0 | 434 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
mentioned in issue gitlab-org/quality/pipeline-triage#296 (closed)
changed milestone to %17.6
added missed:17.5 label
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
- Resolved by Siddharth Dungarwal
@sdungarwal
, thanks for approving this merge request.This is the first time the merge request has been approved. Please ensure the
e2e:test-on-omnibus-ee
job has succeeded. If there is a failure, a Software Engineer in Test (SET) needs to confirm the failures are unrelated to the merge request. If there's no SET assigned to this team, ask for assistance on the#test-platform
Slack channel.
mentioned in merge request !170671 (closed)
removed pipeline:run-e2e-omnibus-once label
changed milestone to %17.5
started a merge train
mentioned in commit 583e92f9
mentioned in incident gitlab-org/release/tasks#13987 (closed)