[backport] Add epic to the scope and fix the flaky spec

What does this MR do and why?

Backport !170270 (merged) to %17.5

This MR fixes group search for epics and work items (issues)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
• The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
• This MR has a severity label assigned (if applicable).
• Set the milestone of the merge request to match the target backport branch version.
• This MR has been approved by a maintainer (only one approval is required).
• Ensure the e2e:test-on-omnibus-ee job has either succeeded or been approved by a Software Engineer in Test.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

• Refer to the patch release runbook for engineers and maintainers for guidance.
• Ask questions on the #releases Slack channel (internal only).

assigned to @terrichu

changed target branch from master to 17-5-stable-ee

changed milestone to %17.5

added groupglobal search typebug labels

added devopsdata stores sectioncore platform labels

marked the checklist item This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch. as completed

marked the checklist item The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes). as completed

marked the checklist item Set the milestone of the merge request to match the target backport branch version. as completed

added pipelinetier-1 label

changed the description

changed title from Draft: Update VERSION files to Draft: [backport] Add epic to the scope and fix the flaky spec

marked this merge request as ready

@sdungarwal would you mind a maintainer review/merge for this backport?

I did not port everything over because there was a spec change in ee/spec/lib/gitlab/elastic/group_search_results_spec.rb that was pretty different from %17.5. Can you take a look and make sure it's ok?

requested review from @sdungarwal

added backend label

	1 Warning
	The e2e:test-on-omnibus-ee job needs to succeed or have approval from a Software Engineer in Test. Read the "QA e2e:test-on-omnibus-ee" section for more details.

	1 Message
	CHANGELOG missing: If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Category	Reviewer	Maintainer
backend	@SamWord (UTC-4, same timezone as author)	@igor.drozdov (UTC+1, 5 hours ahead of author)

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

QA e2e:test-on-omnibus-ee

@terrichu, the e2e:test-on-omnibus job must complete before merging this merge request.*

If there are failures on the e2e:test-on-omnibus pipeline, ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the #test-platform Slack channel.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

mentioned in incident gitlab-org/release/tasks#13828 (closed)

Generated by gitlab_quality-test_tooling.

---

Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.

Click to expand

Job	File	Name	Duration	Expected duration
#8206643349	ee/spec/features/search/elastic/group_search_spec.rb#L134	Group elastic search redactions when we have document_type as work_item behaves like a redacted search results page behaves like redacted search results page assertions when logged in redacts private features the user does not have access to	50.36 s	< 50.13 s
#8212500245	ee/spec/features/search/elastic/group_search_spec.rb#L48	Group elastic search when searching for all scopes except issues and epics finds all the scopes	51.72 s	< 50.13 s

added rspec:slow test detected label