Update group branch modification setting
What does this MR do and why?
Update group branch modification setting
- displays the setting for groups and SPPs that have groups linked to them (as confirmed by the PM)
- requests SPP linked groups
- add setting to setting list
- update yaml
- update tests
References
Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Scenario | Screenshot |
|---|---|
| SPP w/o groups linked | ![]() |
| SPP w/ groups linked | np_-project-_groups_linked_small |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Upload a GitLab Ultimate license
- Enable the feature flag
echo "Feature.enable(:scan_result_policy_block_group_branch_modification)" | rails c - Navigate to a project => Secure => Policies => New policy => Merge request approval policy
- Verify the
Block group branch modificationsetting does not show - Navigate to a group => Secure => Policies => New policy => Merge request approval policy
- Verify the
Block group branch modificationsetting shows and can be toggled and modified - Create the policy
- Navigate to the new SPP created => Secure => Policies => New policy => Merge request approval policy
- Verify the
Block group branch modificationsetting does show - Modify it and create the policy
- Navigate to the project => Secure => Policies => Select the policy => Edit policy
- Verify the policy editor shows the setting
Related to #435725 (closed)
Edited by Alexander Turinske
