NuGet package API: Do not enqueue jobs directly
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you can request access to GitLab Duo.
What does this MR do and why?
This is #329180 (closed), for NuGet.
⚙️ How to test this locally
NuGet packages can be processed in two ways:
- inline within the upload request.
- with a background job.
Both ways can be tested by following the setup described in !176359 (merged). Skip the feature flag steps as it doesn't exist anymore (that change has been released)
Merge request reports
Activity
Thanks for your contribution to GitLab @holtvogt!
🎉 - If you need help, page a coach by clicking here or come say hi on Discord.
- When you're ready, request a review by clicking here.
- We welcome AI-generated contributions and offer complimentary access to GitLab Duo! Check out the top of the merge request description to learn more about using AI while contributing.
This message was generated automatically. You're welcome to improve it.
added 1st contribution Community contribution workflowin dev labels
assigned to @holtvogt
This merge request will be counted as part of the running Hackathon!
Find yourself in the Hackathon Leaderboard or check out the Hackathon page for more information!
🎉 This message was generated automatically. You're welcome to improve it.
added Hackathon label
added docs-only label
added linked-issue label
mentioned in issue #329180 (closed)
2 Warnings ⚠️ This merge request does not refer to an existing milestone. ⚠️ Labels missing: please ask a reviewer or maintainer to add backend to this merge request. Reviewer roulette
Category Reviewer Maintainer backend @minahilnichols
(UTC-5)
@dblessing
(UTC-6)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 DangerEdited by Danger Botremoved docs-only label
marked the checklist item Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you can request access to GitLab Duo. as completed
added 1 commit
- 43e94455 - Add test for NuGet's CreatePackageFileService
added 2 commits
mentioned in issue gitlab-org/quality/triage-reports#20432 (closed)
added grouppackage registry maintenancerefactor labels
added typemaintenance label
changed milestone to %17.6
added devopspackage sectionci labels
- Resolved by Björn Holtvogt
@gitlab-bot ready @10io . Any thoughts on this? Should be similar to !170696 (merged). But maybe there are a few details I should pay attention to
added workflowready for review label and removed workflowin dev label
requested review from @10io
@10io, this Community contribution is ready for review.
- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
- Please ensure the group's Product Manager has validated the linked issue.
This message was generated automatically. Improve it or delete it.
- Resolved by Björn Holtvogt
- Resolved by David Fernandez
- Resolved by Björn Holtvogt
added workflowin dev label and removed workflowready for review label
removed review request for @10io
@holtvogt, it seems we're waiting on an action from you for approximately two weeks.
- Do you still have capacity to work on this? If not, you might want to close this MR and/or ask someone to take over.
- Do you need help in getting it ready? At any time, you can:
- If you're actually ready for a review, you can post
@gitlab-bot ready
.
This message was generated automatically. You're welcome to improve it.
added automation:author-reminded label
added 1 commit
- 97f17b8a - Refactor CreatePackageFileService using responses
added docs-only label
added 1 commit
- 9477b429 - Add response from CreateTemporaryPackageService
removed docs-only label
- Resolved by Björn Holtvogt
@gitlab-bot ready @10io . I’ve incorporated your feedback on the database transaction - thank you for pointing that out! However, I’m unsure whether the
CreateTemporaryPackageService
should rely onCreatePackageFileService
to create the package file (considering SRP). I’d appreciate your thoughts on this. Let me know what you think!Edited by Björn Holtvogt
added workflowready for review label and removed workflowin dev label
requested review from @10io
@10io, this Community contribution is ready for review.
- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
- Please ensure the group's Product Manager has validated the linked issue.
This message was generated automatically. Improve it or delete it.
removed automation:author-reminded label
- Resolved by David Fernandez
- Resolved by David Fernandez
- Resolved by Björn Holtvogt