Skip to content
Snippets Groups Projects

NuGet package API: Do not enqueue jobs directly

  • Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you can request access to GitLab Duo.

What does this MR do and why?

This is #329180 (closed), for NuGet.

⚙️ How to test this locally

NuGet packages can be processed in two ways:

  • inline within the upload request.
  • with a background job.

Both ways can be tested by following the setup described in !176359 (merged). Skip the feature flag steps as it doesn't exist anymore (that change has been released)

Edited by David Fernandez

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • David Fernandez removed review request for @10io

    removed review request for @10io

  • @holtvogt, it seems we're waiting on an action from you for approximately two weeks.

    This message was generated automatically. You're welcome to improve it.

  • added 1 commit

    • 97f17b8a - Refactor CreatePackageFileService using responses

    Compare with previous version

  • added 1 commit

    • 4fdba0e9 - Add CreateTemporaryPackageService for NuGet

    Compare with previous version

  • added 1 commit

    • 144bbd2e - 1 commit from branch gitlab-org:master

    Compare with previous version

  • added 1 commit

    • 9477b429 - Add response from CreateTemporaryPackageService

    Compare with previous version

    • Author Contributor
      Resolved by Björn Holtvogt

      @gitlab-bot ready @10io . I’ve incorporated your feedback on the database transaction - thank you for pointing that out! However, I’m unsure whether the CreateTemporaryPackageService should rely on CreatePackageFileService to create the package file (considering SRP). I’d appreciate your thoughts on this. Let me know what you think!

      Edited by Björn Holtvogt
  • 🤖 GitLab Bot 🤖 requested review from @10io

    requested review from @10io

  • @10io, this Community contribution is ready for review.

    • Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
    • If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
    • Please ensure the group's Product Manager has validated the linked issue.

    This message was generated automatically. Improve it or delete it.

  • added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading