Skip to content

Update policy editor for group protected branches

Alexander Turinskerequested to merge
435725-update-ui-to-reference-groups into master

What does this MR do and why?

Update policy editor for group protected branches

  • exceptions apply to groups, not branches
  • group protected branches only apply to top-level groups at this time
  • the exceptions need to include the groups' full path
  • update tests

Changelog: changed

EE: true

References

Please include cross links to any resources that are relevant to this MR This will give reviewers and future readers helpful context to give an efficient review of the changes introduced.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-10-24_at_20.29.43 setting_-_after

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Upload a GitLab Ultimate license
  2. Enable the feature flag echo "Feature.enable(:scan_result_policy_block_group_branch_modification)" | rails c
  3. Navigate to a group => Secure => Policies => New policy => Merge request approval policy
  4. Verify the Block group branch modification setting shows and can be toggled and modified

Related to #435725 (closed)

Merge request reports