Use commit changes modal for edit blob
What does this MR do and why?
Update to use commit modal in edit blob flow.
Part 2 of #444302 (closed)
Implementation breakdown:
| Description | MR |
|---|---|
| update exiting delete blob modal | !168992 (merged) |
| use new modal for edit flow |
|
| update doc | #502863 (closed) |
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After | |
|---|---|---|
|
Edit file to current branch and user can push to the branch Expected: Users should see two radio options (one to commit to current branch, one to commit to a new branch) and a checkbox to create MR. |
||
|
Edit file to current branch and user can NOT push to the branch How to set up:
Expected: Users should see the text input for entering a new branch name and a checkbox to create MR. |
||
|
Edit file to new branch and open a MR |
||
|
Edit file to new branch and NOT open a MR |
||
|
Edit LFS file How to set up:
|
||
|
Edit while collaboration on merge requests across forks How to set up:
Expected: Users should see the following message: "Your changes can be committed to %{branchName} because a merge request is open" |
||
|
Editing a file that has been edited by another user as a user with permission How to set up:
Expected: Users should see the error toast with the following message: "Someone edited the file the same time you did. Please check out the file and make sure your change will not unintentionally remove theirs". " |
||
|
Editing a file that has been edited by another user as a user without permission How to set up:
Expected: Users should see the error toast with the following message: "Error: Can't edit this file. The fork and upstream project have diverged. Edit the file on the fork". |
||
|
Edit file from merge request Steps:
Expected: Users should be bought back to the merge request |
||
| Cancel button pops a confirmation modal | ||
| On smaller screen |
How to set up and validate locally
-
Open a file in repo
-
Select "Edit" > "Edit Single File"
-
Select "Commit changes"
-
A modal should pop up
See more details on each flow in table above
🔼
Related to #444302 (closed)

