Extracts Resolve Vulnerability completion helpers
What does this MR do and why?
This MR is a simplified version of Add AIGW service class for resolve_vulnerability (!165884 - closed).
The purpose of this change is to extract shared code so that it can be used by the current completion (Gitlab::Llm::Completions::ResolveVulnerability
) and the new implementation (Gitlab::Llm::AiGateway::Completions::ResolveVulnerability
) which will be added in a follow up MR.
There are no functional changes in this MR, and the existing completion is tested in https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/spec/lib/gitlab/llm/completions/resolve_vulnerability_spec.rb
All methods in the helper file are private, so no tests were moved as part of the extraction, and no new tests were added.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
changed milestone to %17.6
assigned to @darbyfrey
added pipelinetier-1 label
- A deleted user
added backend label
Reviewer roulette
Category Reviewer Maintainer backend @hmerscher
(UTC+2)
@dskim_gitlab
(UTC+11)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Michael Becker
- Resolved by Michael Becker
- Resolved by Michael Becker
- Resolved by Michael Becker
- Resolved by Michael Becker
- Resolved by Michael Becker
- Resolved by Michael Becker
@subashis this is the first part of breaking down !165884 (closed), would you mind giving this a backend review?
requested review from @subashis
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for bde3dcbbexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 45 | 0 | 2 | 0 | 47 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Create | 129 | 0 | 19 | 0 | 148 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Govern | 75 | 0 | 3 | 0 | 78 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 17 | 0 | 18 | 0 | 35 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 397 | 0 | 44 | 0 | 441 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for bde3dcbbexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 139 | 0 | 21 | 17 | 160 | ✅ | | Govern | 79 | 0 | 11 | 8 | 90 | ✅ | | Plan | 86 | 0 | 8 | 12 | 94 | ✅ | | Verify | 50 | 0 | 15 | 10 | 65 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 1 | 0 | 5 | 0 | 6 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 430 | 0 | 121 | 47 | 551 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
requested review from @wandering_person
started a merge train
removed this merge request from the merge train because the pipeline did not succeed. Learn more.
- Resolved by Michael Becker
- Resolved by Michael Becker
- Resolved by Michael Becker
- Resolved by Michael Becker
- Resolved by Michael Becker
- Resolved by Michael Becker
started a merge train
removed this merge request from the merge train because the pipeline did not succeed. Learn more.
started a merge train
mentioned in commit aeca491a
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#9119 (closed)
mentioned in merge request !170867 (closed)
mentioned in merge request !165884 (closed)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
mentioned in merge request !174784 (merged)
added releasedpublished label and removed releasedcandidate label