Model registry: Add Artifacts tab to Version card
What does this MR do and why?
This MR adds a new tab called Artifacts
and moves the artifacts from the Version card
to the new tab.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Open GDK: http://127.0.0.1:3000/flightjs/Flight/-/ml/models
- Create model if one doesn't exist, give it a model name and a model version click
Create
- Click on the just created version
- Verify that the version card has a tab called "artifacts" in accordance with the screenshot. Numbered steps to set up and validate the change are strongly suggested.
Related to #498604 (closed)
Merge request reports
Activity
changed milestone to %17.6
assigned to @fdegier
added 2952 commits
-
ef9658f6...371412a9 - 2951 commits from branch
master
- 7a7f488b - Model registry: Add artifacts tab on Version card
-
ef9658f6...371412a9 - 2951 commits from branch
- A deleted user
added frontend label
3 Warnings d71910c1: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request contains lines with testid selectors. Please ensure e2e:test-on-omnibus
job is run.testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/assets/javascripts/ml/model_registry/components/model_version_artifacts.vue
+ <h3 data-testid="uploadHeader" class="gl-text-lg">
app/assets/javascripts/ml/model_registry/components/model_version_detail.vue
- <h3 data-testid="uploadHeader" class="gl-mt-5 gl-text-lg">
If the
e2e:test-on-omnibus
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:test-on-omnibus-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @cindy-halim
(UTC-5, 6 hours behind author)
@apennells
(UTC-5, 6 hours behind author)
~"Tooling" Reviewer review is optional for ~"Tooling" @tristan.read
(UTC+13, 12 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 4e261430 and d71910c1
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.4 MB 4.4 MB - 0.0 % mainChunk 3.31 MB 3.31 MB - 0.0 % Significant Growth: 7Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.ml.model_versions.edit 1.41 MB 1.45 MB +42.86 KB 3.0 % pages.projects.ml.model_versions.new 1.41 MB 1.45 MB +42.86 KB 3.0 % pages.projects.ml.model_versions.show 1.41 MB 1.45 MB +42.86 KB 3.0 % pages.projects.ml.models.edit 1.41 MB 1.45 MB +42.86 KB 3.0 % pages.projects.ml.models.index 1.41 MB 1.45 MB +42.86 KB 3.0 % pages.projects.ml.models.new 1.41 MB 1.45 MB +42.86 KB 3.0 % pages.projects.ml.models.show 1.41 MB 1.45 MB +42.86 KB 3.0 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@pgascouvaillancourt
,@sdejonge
or@thutterer
) for review, if you are unsure about the size increase.Note: We do not have exact data for 4e261430. So we have used data from: 1cb3e872.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 11 commits
-
7a7f488b...71728536 - 10 commits from branch
master
- ef080a09 - Model registry: Add artifacts tab on Version card
-
7a7f488b...71728536 - 10 commits from branch
added 1 commit
- af9dbeb9 - Model registry: Add artifacts tab on Version card
- Resolved by Fred de Gier
- Resolved by Alper Akgun
- Resolved by Alper Akgun
- Resolved by Fred de Gier
Thanks @fdegier small notes;
also can you rebase to get the sidebar which was just merged; we can see and also update the screenshots.
added 183 commits
-
af9dbeb9...88293521 - 182 commits from branch
master
- 6a01b432 - Model registry: Add artifacts tab on Version card
-
af9dbeb9...88293521 - 182 commits from branch
mentioned in issue #502189 (closed)
removed review request for @a_akgun
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels
- Resolved by Elwyn Benson
@elwyn-gitlab could you do the frontend maintainer review?
requested review from @elwyn-gitlab
- Resolved by Elwyn Benson
- Resolved by Elwyn Benson
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for d71910c1expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Verify | 45 | 0 | 2 | 0 | 47 | ✅ | | Create | 129 | 0 | 22 | 0 | 151 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Govern | 75 | 0 | 3 | 0 | 78 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 17 | 0 | 18 | 0 | 35 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 397 | 0 | 48 | 0 | 445 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for d71910c1expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 84 | 0 | 9 | 2 | 93 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Verify | 50 | 0 | 15 | 0 | 65 | ✅ | | Create | 139 | 0 | 21 | 0 | 160 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 1 | 0 | 6 | 0 | 7 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 435 | 0 | 120 | 2 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
aborted automatic add to merge train because the source branch was updated. Learn more.
added 1 commit
- d71910c1 - Model registry: Add artifacts tab on Version card
Thanks @elwyn-gitlab turned out that one of the specs is now compatible with Vue3 and the pipeline failed https://gitlab.com/gitlab-org/gitlab/-/jobs/8266858343#L1145 I've removed it from the quarantined file. Can you set it to MWPS again?
reset approvals from @a_akgun and @elwyn-gitlab by pushing to the branch
started a merge train
mentioned in commit 85952a23
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label