Skip to content

restrict individual approvers to project members

Simon Knox requested to merge 1593-limited-approvers into master

What does this MR do?

Only show users with access to the project in the Approvers dropdown

Are there points in the code the reviewer needs to double check?

not sure the best place to add tests. Some options:

  • make selects_helper_spec.rb for users_select_tag
  • tests for approvers_select and move MR page to use that

Why was this MR needed?

Screenshots (if relevant)

User 1 without access

Settings page:

Screen_Shot_2017-04-21_at_9.22.59_am

MR Page:

Screen_Shot_2017-04-21_at_9.23.13_am

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #1593 (closed)

Merge request reports