Increase and sort number of options displayed for cycle analytics projects dropdown
What does this MR do?
Increase number of options displayed for cycle analytics projects dropdown and sort results by last_activity_at
Screenshots
Does this MR meet the acceptance criteria?
Conformity
Related to #31937 (closed)
Merge request reports
Activity
changed milestone to %12.3
added devopsmanage groupoptimize typebug labels
assigned to @blabuschagne
added 20 commits
- 06ce2aa1 - Allow disabling group/project email notifications
- 564942bd - FE for group level Cycle Analytics
- 9bda5836 - Destructure table data for stages
- 87703339 - Call createFlash within error actions
- d591e0d7 - Added issue stage spec
- f40948e0 - Separate class for merge-request and issue links
- a9c12e59 - Replace analytics stage-nav-item with vue component
- 10edb9d6 - Updated specs to use stage-event-list
- 9e98dbff - Minor review feedback
- 8465d42e - Rename getCurrentStage => currentStage
- 8c35ea4e - Move stage headers to separate component
- 9f46d5d0 - Generate fixtures with cycle data
- b91bb3ec - Added fixture generate for issues.json endpoint
- 1bdbe689 - Added plan and review stage fixtures
- 15826071 - Replace test, code, staging and production mocks
- 5a964bd5 - Use GlEmptyState for no access and empty states
- 011350cf - Added DEFAULT_DATA_TIME_FRAME to constants
- f311d8d9 - Added utility classes for active/inactive stage_card_item
- 5988f56b - Migrate add customizable stage button
- 75038ffd - Added feature flag check for customizableCycleAnalytics
Toggle commit listadded 1 commit
- d68d8d91 - Increase results displayed in projects filter
1 Warning The title of this merge request is longer than 72 characters and would violate our commit message rules when using the Squash on Merge feature. Please consider adjusting the title, or rebase the commits manually and don’t use Squash on Merge. 1 Message CHANGELOG missing: If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message. You can create one with:
bin/changelog -m 16906 "Increase and sort number of options displayed for cycle analytics projects dropdown"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 16906 "Increase and sort number of options displayed for cycle analytics projects dropdown"
Note: Merge requests with ~backstage, ci-build, meta do not trigger this check.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer frontend Justin Boyson ( @jboyson
)Mike Greiling ( @mikegreiling
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖@wortschi could you please perform an initial review on this and advise if you think a test is necessary?
assigned to @wortschi
mentioned in issue #31937 (closed)
- Resolved by Brandon Labuschagne
@blabuschagne This looks good to me
As for testing, it's def. nice to have. Is this a time sensitive fix and if so do you think adding a spec would be a big effort? FYI - I have approved this already.One test that would make sense imho is to test whether the object passed via
projectsQueryParams
is actually being passed to the API call. Thoughts?Edited by Martin Wortschack
unassigned @blabuschagne
assigned to @blabuschagne and unassigned @wortschi
added 1 commit
-
0d1e2746 - 1 commit from branch
group-level-cycle-analytics-refactor
-
0d1e2746 - 1 commit from branch
changed milestone to %12.4
added 249 commits
-
0d1e2746...4106b658 - 249 commits from branch
master
-
0d1e2746...4106b658 - 249 commits from branch
added 1 commit
- 20404fac - Increase results displayed in projects filter
added 1 commit
- 8a5eb4f7 - Increase results displayed in projects filter
assigned to @wortschi
unassigned @wortschi
@pslaughter could you please perform a final review on this and merge if happy?
P.S. no changelog has been added as this is still behind a feature flag
assigned to @pslaughter
added 78 commits
-
8a5eb4f7...b3078831 - 77 commits from branch
master
- 391829b5 - Increase results displayed in projects filter
-
8a5eb4f7...b3078831 - 77 commits from branch
- Resolved by Paul Slaughter
thought: Would you consider adding
{ order_by: 'name', sort: 'asc' }
to theprojectsQueryParams
? On.com
, it's pretty hard to find what you're looking for since it's unsorted
- Resolved by Brandon Labuschagne
- Resolved by Paul Slaughter
- Resolved by Brandon Labuschagne
- Resolved by Brandon Labuschagne
- Resolved by Paul Slaughter
Sorry it took me a while to get to this
Back to you @blabuschagne!
unassigned @pslaughter
added 303 commits
-
391829b5...a93b0bb9 - 302 commits from branch
master
- 0f68359b - Increase results displayed in projects filter
-
391829b5...a93b0bb9 - 302 commits from branch
assigned to @wortschi
unassigned @wortschi
added 1 commit
- 60ec56ee - Increase results displayed in projects filter
assigned to @pslaughter
mentioned in issue #32330 (closed)
- Resolved by Paul Slaughter
Failing pipeline is not related to this MR but I'll rebase as soon as master is green again!