Skip to content
Snippets Groups Projects

Labels page: Fix vertical alignment and badge

Merged Sascha Eggenberger requested to merge labels-page-fix-alignment-and-badge into master
All threads resolved!

What does this MR do and why?

Labels page: Fix vertical alignment and badge

Reported by @markrian via https://gitlab.slack.com/archives/CETG54GQ0/p1728574613210179

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
before after
before2 after2

How to set up and validate locally

  1. Group: http://gdk.test:3000/groups/flightjs/-/labels
  2. Project: http://gdk.test:3000/flightjs/Flight/-/labels
  3. Admin: http://gdk.test:3000/admin/labels

Related to #474921 (closed)

Edited by Sascha Eggenberger

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks for the fast fix, @seggenberger!

    I think the way padding/margins are implemented in the list of labels could be simpler, but this fixes the immediate layout issues, so let's go with this.

  • Mark Florian enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 6bdc6cb4

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 128    | 0      | 18      | 0     | 146   | ✅     |
    | Plan        | 76     | 0      | 0       | 0     | 76    | ✅     |
    | Package     | 24     | 0      | 11      | 0     | 35    | ✅     |
    | Verify      | 45     | 0      | 2       | 0     | 47    | ✅     |
    | Govern      | 73     | 0      | 0       | 0     | 73    | ✅     |
    | Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Data Stores | 33     | 0      | 1       | 0     | 34    | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Secure      | 4      | 0      | 0       | 0     | 4     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 401    | 0      | 33      | 0     | 434   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • Hey there :wave:, could you please make sure this merge request gets merged?

    The merge request is set to auto-merge, but it is not currently mergeable (MR detailed_merge_status is discussions_not_resolved).

    This message was generated automatically. You're welcome to improve it.

  • Sascha Eggenberger resolved all threads

    resolved all threads

  • merged

  • Mark Florian mentioned in commit 21d09ea3

    mentioned in commit 21d09ea3

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading