Update Model registry empty state illustration
What does this MR do and why?
Replace outdated illustration with a new one. Old illustration will be removed from the library since it's not follow brand style.
What does not this MR do?
- Doesn't hide header. There should be a separate work on this since it involves transferring modals somewhere else.
- Doesn't separate empty state and empty result state. Because it relates to modal work listed above.
- Doesn't update inner pages. I need some context to update them.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
Merge request reports
Activity
changed milestone to %17.5
added UX Paper Cuts groupmlops typemaintenance labels
assigned to @jmiocene
added devopsmodelops sectiondata-science labels
added pipelinetier-1 label
mentioned in epic &12912
- A deleted user
added frontend label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer backend @tyleramos
(UTC-4, 6 hours behind author)
@eugielimpin
(UTC+8, 6 hours ahead of author)
frontend @marina.mosti
(UTC+2, same timezone as author)
@mlunoe
(UTC+2, same timezone as author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1 commit
- 9ba985ef - Update Model registry empty state illustration
- A deleted user
added backend label
added 1 commit
- 028c87c0 - Update Model registry empty state illustration
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits f1f83c6a and 028c87c0
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.39 MB 4.39 MB - 0.0 % mainChunk 3.3 MB 3.3 MB - 0.0 %
Note: We do not have exact data for f1f83c6a. So we have used data from: 9b3ee283.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangermentioned in merge request gitlab-svgs!1098 (merged)
- Resolved by Julia Miocene
@seggenberger
Could you please review UX here? There is a list of follow-ups in the description. So, in this MR I only change the ilustration.
requested review from @seggenberger
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 028c87c0expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 128 | 0 | 18 | 0 | 146 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Govern | 73 | 0 | 0 | 0 | 73 | ✅ | | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Verify | 45 | 0 | 2 | 0 | 47 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Package | 24 | 0 | 11 | 0 | 35 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 401 | 0 | 33 | 0 | 434 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 028c87c0expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 139 | 0 | 20 | 13 | 159 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Plan | 86 | 0 | 8 | 8 | 94 | ✅ | | Verify | 50 | 0 | 15 | 10 | 65 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Govern | 82 | 0 | 7 | 9 | 89 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Secure | 4 | 0 | 2 | 0 | 6 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 436 | 0 | 113 | 40 | 549 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Julia Miocene
@bmarjanovic
Could you please do a maintainer backend review here? It's a UI change, but DangerBot asks for a backend review. So, I go straight to maintainer
requested review from @bmarjanovic
- Resolved by Michael Lunøe
@fernando-c
Could you please review frontend here?
requested review from @fernando-c
removed review request for @bmarjanovic
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
requested review from @mlunoe
started a merge train
mentioned in commit 2727172b
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label