Skip to content

Refactor blobs_controller blob and commit methods

Joe Woodward requested to merge chore/refactor-blob-controller-blob-method into master

What does this MR do and why?

  • remove redirect logic from #blob and #commit methods
  • create before_action method ensure_blob! and ensure_commit! to handle redirects
  • strong_memoizes blob and commit methods
  • abstract redirection logic for blobs
  • removes if else statement from blob method
  • removes calls to @blob in favor of blob
  • removes calls to @commit in favor of commit

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Joe Woodward

Merge request reports

Loading