New on-demand scan: Migreate page heading to shared component
What does this MR do and why?
New on-demand scan: Migreate page heading to shared pageHeading
component
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Related to #474921 (closed)
Merge request reports
Activity
changed milestone to %17.5
assigned to @seggenberger
added devopsfoundations label
added devopsgovern label and removed devopsfoundations label
- Resolved by Sascha Eggenberger
requested review from @annabeldunstone
added devopsfoundations groupux paper cuts sectioncore platform labels and removed devopsgovern groupcompliance sectiondev labels
added pipelinetier-1 label
2 Warnings bb87177e: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. This merge request contains lines with testid selectors. Please ensure e2e:test-on-omnibus
job is run.testid
selectorsThe following changed lines in this MR contain
testid
selectors:ee/app/assets/javascripts/on_demand_scans_form/components/on_demand_scans_form.vue
- <gl-link :href="$options.helpPagePath" data-testid="help-page-link"> + <gl-link :href="$options.helpPagePath" data-testid="help-page-link">{{
If the
e2e:test-on-omnibus
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:test-on-omnibus-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @anastasia.khom
(UTC-4, 6 hours behind author)
@himkp
(UTC+2, same timezone as author)
UX @cam.x
(UTC+0, 2 hours behind author)
Maintainer review is optional for UX Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded groupcompliance label and removed groupux paper cuts label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 65f4a035 and bb87177e
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.38 MB 4.38 MB - 0.0 % mainChunk 3.31 MB 3.31 MB - 0.0 %
Note: We do not have exact data for 65f4a035. So we have used data from: f4b170f4.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 1 commit
- cadcf1f0 - New on-demand scan: Migreate page heading to shared component
added 1 commit
- 3968cc7e - New on-demand scan: Migreate page heading to shared component
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger
removed review request for @annabeldunstone
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for bb87177eexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 45 | 0 | 2 | 0 | 47 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Create | 128 | 0 | 18 | 0 | 146 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Govern | 73 | 0 | 0 | 0 | 73 | ✅ | | Package | 24 | 0 | 11 | 0 | 35 | ✅ | | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 401 | 0 | 33 | 0 | 434 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
requested review from @nradina
added 1 commit
- df1a42a7 - New on-demand scan: Migreate page heading to shared component
added 435 commits
-
df1a42a7...8505448b - 434 commits from branch
master
- bb87177e - New on-demand scan: Migreate page heading to shared component
-
df1a42a7...8505448b - 434 commits from branch
- Resolved by Brandon Labuschagne
- Resolved by Brandon Labuschagne
- Resolved by Brandon Labuschagne
@seggenberger great work! I left one non-blocking suggestion and approving!
requested review from @djadmin
removed review request for @djadmin
requested review from @blabuschagne
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
added this merge request to the merge train at position 2
mentioned in commit dc893536
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label