Skip to content
Snippets Groups Projects

New on-demand scan: Migreate page heading to shared component

Merged Sascha Eggenberger requested to merge new-on-demand-scan-migrate-header into master
All threads resolved!

What does this MR do and why?

New on-demand scan: Migreate page heading to shared pageHeading component

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
before after

How to set up and validate locally

  1. http://gdk.test:3000/flightjs/Flight/-/on_demand_scans/new

Related to #474921 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • removed review request for @annabeldunstone

  • Annabel Dunstone Gray approved this merge request

    approved this merge request

  • added pipelinetier-2 label and removed pipelinetier-1 label

  • Before you set this MR to auto-merge

    This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.

    Before you set this MR to auto-merge, please check the following:

    • You are the last maintainer of this merge request
    • The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
    • This pipeline is recent enough (created in the last 8 hours)

    If all the criteria above apply, please set auto-merge for this merge request.

    See pipeline tiers and merging a merge request for more details.

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for bb87177e

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Verify      | 45     | 0      | 2       | 0     | 47    | ✅     |
    | Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
    | Create      | 128    | 0      | 18      | 0     | 146   | ✅     |
    | Data Stores | 33     | 0      | 1       | 0     | 34    | ✅     |
    | Govern      | 73     | 0      | 0       | 0     | 73    | ✅     |
    | Package     | 24     | 0      | 11      | 0     | 35    | ✅     |
    | Plan        | 76     | 0      | 0       | 0     | 76    | ✅     |
    | Secure      | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 401    | 0      | 33      | 0     | 434   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
  • added 1 commit

    • ffe9b0bd - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    • 81d691e6 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Sascha Eggenberger resolved all threads

    resolved all threads

  • Hey @nradina can you do the frontend review here? TY!

  • requested review from @nradina

  • added 1 commit

    • df1a42a7 - New on-demand scan: Migreate page heading to shared component

    Compare with previous version

  • Sascha Eggenberger added 435 commits

    added 435 commits

    Compare with previous version

  • Nataliia Radina
  • Nataliia Radina
  • Nataliia Radina approved this merge request

    approved this merge request

  • Nataliia Radina requested review from @djadmin

    requested review from @djadmin

  • Nataliia Radina removed review request for @djadmin

    removed review request for @djadmin

  • requested review from @blabuschagne

  • Brandon Labuschagne approved this merge request

    approved this merge request

  • Brandon Labuschagne resolved all threads

    resolved all threads

  • Brandon Labuschagne enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Brandon Labuschagne added this merge request to the merge train at position 2

    added this merge request to the merge train at position 2

  • mentioned in commit dc893536

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading