Warn before applying issue template

What does this MR do?

Adds a content override warning when applying another template.

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios.
• Documentation created/updated or follow-up review issue created
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Closes #16188 (closed)

changed milestone to %12.3

added Deferred UX Plan [DEPRECATED] description templates devopsplan frontend groupproject management internal customer issues priority3 typefeature workflowin dev + 1 deleted label

GitLab FOSS MR: gitlab-foss!31256 (closed)

@annabeldunstone would you mind reviewing this one again? I fixed the issue you described in the 2nd item of this comment.

assigned to @annabeldunstone

	1 Warning
	This merge request changed files with disabled eslint rules. Please consider fixing them.

Disabled eslint rules

The following files have disabled eslint rules. Please consider fixing them:

• app/assets/javascripts/blob/template_selector.js
• app/assets/javascripts/gl_dropdown.js
• app/assets/javascripts/pages/projects/issues/form.js
• app/assets/javascripts/pages/projects/merge_requests/init_merge_request.js
• app/assets/javascripts/templates/issuable_template_selector.js
• app/assets/javascripts/templates/issuable_template_selectors.js

Run the following command for more details

node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \
  'app/assets/javascripts/blob/template_selector.js' \
  'app/assets/javascripts/gl_dropdown.js' \
  'app/assets/javascripts/pages/projects/issues/form.js' \
  'app/assets/javascripts/pages/projects/merge_requests/init_merge_request.js' \
  'app/assets/javascripts/templates/issuable_template_selector.js' \
  'app/assets/javascripts/templates/issuable_template_selectors.js'

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

Category	Reviewer	Maintainer
frontend	Mark Florian (@markrian)	Tim Zallmann (@timzallmann)
test for spec/features/*	Walmyr Lima e Silva Filho (@wlsf82)	No maintainer available

Generated by Danger

@fatihacet Looks great! One last thing I notice:

If you select a template after entering a description, and then hit Cancel on the alert, the dropdown still has the name of the template you chose (in this case, Bug):

Can we reset that dropdown to go back to Choose a template?

assigned to @fatihacet and unassigned @annabeldunstone

mentioned in issue #32526 (closed)

added missed:12.3 label

mentioned in issue #32730 (closed)

changed milestone to %12.4

added 1419 commits

• fff6b4dd...969d098e - 1418 commits from branch master
• 32fbd410 - Warn before applying issue template

Compare with previous version

added 97 commits

• 32fbd410...9ebf5671 - 96 commits from branch master
• 10b449c9 - Warn before applying issue template

Compare with previous version

added 1 commit

• 21a9513d - Warn before applying issue template

Compare with previous version

added 1 commit

• 12c7ca58 - Warn before applying issue template

Compare with previous version

@kushalpandya can you please review this?

assigned to @kushalpandya

Thanks @fatihacet, left just 1 suggestion.

unassigned @kushalpandya

resolved all threads

added 268 commits

• 12c7ca58...80e49607 - 267 commits from branch master
• 5ab7e34b - Warn before applying issue template

Compare with previous version

assigned to @kushalpandya

resolved all threads

approved this merge request

merged

mentioned in commit 2df7df79

This merge request has been deployed to the GitLab.com environment gstg in GitLab auto-deploy version 12.4.201910060810-7f9c8d918a6.7d9da866292.

A list of all the deployed commits can be found here.

---

If this message is incorrect, please create an issue in the Release Tools project.

added workflowstaging label and removed workflowin dev label

This merge request has been deployed to the GitLab.com environment gprd-cny in GitLab auto-deploy version 12.4.201910060810-7f9c8d918a6.7d9da866292.

A list of all the deployed commits can be found here.

---

If this message is incorrect, please create an issue in the Release Tools project.

added workflowcanary label and removed workflowstaging label

This merge request has been deployed to the GitLab.com environment gprd in GitLab auto-deploy version 12.4.201910071518-933febe7c6d.aae3944cae6.

A list of all the deployed commits can be found here.

---

If this message is incorrect, please create an issue in the Release Tools project.

added workflowproduction label and removed workflowcanary label

mentioned in merge request !18334 (merged)

removed Plan [DEPRECATED] label