Secure policies: Update header to use shared component
What does this MR do and why?
Secure policies:
- Migrate header to use shared
pageHeading
component - Fixes a bug where the page name would not show up in the browser chrome bar
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Related to #474921 (closed)
Merge request reports
Activity
changed milestone to %17.5
assigned to @seggenberger
added UX UX Paper Cuts frontend maintenancerefactor sectiondev typemaintenance labels
added devopsfoundations groupux paper cuts labels
added groupsecurity policies label and removed devopsfoundations groupux paper cuts labels
added devopsfoundations label
added Category:Security Policy Management devopsgovern labels and removed devopsfoundations label
- Resolved by Sheldon Led
requested review from @annabeldunstone
added devopsfoundations groupux paper cuts sectioncore platform labels and removed devopsgovern groupsecurity policies sectiondev labels
added pipelinetier-1 label
- A deleted user
added backend label
1 Warning This merge request contains lines with testid selectors. Please ensure e2e:test-on-omnibus
job is run.testid
selectorsThe following changed lines in this MR contain
testid
selectors:ee/app/assets/javascripts/security_orchestration/components/policies/list_header.vue
- <p data-testid="policies-subheader"> + data-testid="more-information-link"
If the
e2e:test-on-omnibus
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:test-on-omnibus-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer backend @ddieulivol
(UTC+2, same timezone as author)
@egrieff
(UTC+2, same timezone as author)
frontend @vanessaotto
(UTC+2, same timezone as author)
@sheldonled
(UTC+1, 1 hour behind author)
UX @jmiocene
(UTC+2, same timezone as author)
Maintainer review is optional for UX Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 7416a0a7 and 2d105d5e
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.39 MB 4.39 MB - 0.0 % mainChunk 3.3 MB 3.3 MB - 0.0 %
Note: We do not have exact data for 7416a0a7. So we have used data from: cb084a5c.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangerremoved review request for @annabeldunstone
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 2d105d5eexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Govern | 73 | 0 | 0 | 0 | 73 | ✅ | | Verify | 45 | 0 | 2 | 0 | 47 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Create | 128 | 0 | 18 | 0 | 146 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 24 | 0 | 11 | 0 | 35 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 401 | 0 | 33 | 0 | 434 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 2d105d5eexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 86 | 0 | 8 | 8 | 94 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Verify | 50 | 0 | 15 | 10 | 65 | ✅ | | Create | 139 | 0 | 20 | 13 | 159 | ✅ | | Govern | 82 | 0 | 7 | 9 | 89 | ✅ | | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Secure | 4 | 0 | 2 | 0 | 6 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 436 | 0 | 113 | 40 | 549 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Sheldon Led
Hey @thomasrandolph can you do the frontend review here?
requested review from @thomasrandolph
- Resolved by Sheldon Led
requested review from @sheldonled
changed milestone to %17.6
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
removed review request for @thomasrandolph
started a merge train
mentioned in commit cd9774fe
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label