Skip to content
Snippets Groups Projects

Secure policies: Update header to use shared component

Merged Sascha Eggenberger requested to merge sec-policies-migrate-header into master
All threads resolved!

What does this MR do and why?

Secure policies:

  • Migrate header to use shared pageHeading component
  • Fixes a bug where the page name would not show up in the browser chrome bar

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
before after

How to set up and validate locally

  1. http://gdk.test:3000/flightjs/Flight/-/security/policies

Related to #474921 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thomas Randolph approved this merge request

    approved this merge request

  • requested review from @sheldonled

  • Sascha Eggenberger changed milestone to %17.6

    changed milestone to %17.6

  • Sheldon Led approved this merge request

    approved this merge request

  • Sheldon Led removed review request for @thomasrandolph

    removed review request for @thomasrandolph

  • Sheldon Led resolved all threads

    resolved all threads

  • Sheldon Led enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • merged

  • Sheldon Led mentioned in commit cd9774fe

    mentioned in commit cd9774fe

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading