Sticky submit buttons in work item epic modal
What does this MR do and why?
Resolves #497863 (closed)
- Sticky submit buttons in work item epic modal
- Make work item create modal scrollable (slightly less tall)
Changelog: changed
Before | After |
---|---|
![]() |
![]() |
non-modal is same | ![]() |
How to set up and validate locally
- In rails console
Feature.enable(:namespace_level_work_items)
- Go to
epics/new
page and look at the buttons - In left sidebar, go to
+
button and New Epic - Look at those buttons
- Change window width/height and check things don't look weird
- Look at those buttons
- Click on the
icon to open the form in a new page - Look at those buttons
Merge request reports
Activity
changed milestone to %17.5
assigned to @psimyn
added pipelinetier-1 label
53 Warnings This MR has a Changelog commit for EE, but no code changes in ee/
. Consider removing theEE: true
trailer from your commits.22a54069: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. d9beb17f: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. ea3a13bd: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. ea3a13bd: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. ea3a13bd: Use full URLs instead of short references ( gitlab-org/gitlab#123
or!123
), as short references are displayed as plain text outside of GitLab. For more information, take a look at our Commit message guidelines.df81b0d7: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 08e2a938: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 0b222251: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. bc0f2291: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 43d62e64: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 7fb7b4d9: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. 849e2394: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 05a47882: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. defec026: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. 808c8b9f: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 269edb35: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. b91cce20: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. a5afbf47: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 5c09749a: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. acb1469f: Use full URLs instead of short references ( gitlab-org/gitlab#123
or!123
), as short references are displayed as plain text outside of GitLab. For more information, take a look at our Commit message guidelines.32ed70ef: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. f62ecb9b: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 5b2be801: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1482fbc5: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. a89d0efe: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. effa9b07: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 015af638: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. 0d1cca13: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 2743d238: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 4809632e: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. a67719e2: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. 734b2acf: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 7b70cbdf: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 3abc26fd: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. 23443ff5: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. e9d05ffe: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 4adb8577: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 076ee29d: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 22336e9e: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. c977d261: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 1d426581: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 2297f0eb: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 44c76d67: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. 44c76d67: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 2144bdac: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 30376537: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. 36b0d0ce: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. 36b0d0ce: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines. 94abfdbd: The commit subject and body must be separated by a blank line. For more information, take a look at our Commit message guidelines. This merge request has more than 20 commits which may cause issues in some of the jobs. If you see errors like missing commits, please consider squashing some commits so it is within 20 commits. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request contains lines with testid selectors. Please ensure e2e:test-on-omnibus
job is run.testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/assets/javascripts/work_items/components/create_work_item.vue
+ data-testid="form-buttons" + data-testid="form-buttons" + <gl-button type="button" data-testid="cancel-button" @click="handleCancelClick"> + data-testid="create-button"
If the
e2e:test-on-omnibus
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:test-on-omnibus-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @leetickett-gitlab
(UTC+0, 11 hours behind author)
@ntepluhina
(UTC+1, 10 hours behind author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue #497863 (closed)
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 9a871e1d and 7efbc3e7
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.46 MB 4.46 MB - 0.0 % mainChunk 3.36 MB 3.36 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
Dangerchanged milestone to %17.6
added missed:17.5 label
added 6307 commits
-
87afb09a...bd5f81b8 - 6305 commits from branch
master
- 5faba9eb - Merge branch 'master' of gitlab.com:gitlab-org/gitlab into psi-wi-modal-buttons
- 2d1a1e8e - Fix non modal view
-
87afb09a...bd5f81b8 - 6305 commits from branch
requested review from @jachapman and @nickleonard
- Resolved by Simon Knox
Hey @psimyn I think the code is all good but I wanted to double check the position of the buttons on the /new page. I'm seeing the following:
master
psi-wi-modal-buttons
- Resolved by Stanislav Lashmanov
@psimyn This is looking good
small gap below sticky row: There's a gap where content is visible below the buttons (see the cutoff "None" at the bottom)
description size: In the design the description height grows to fill the available space. I'm fine with this as a follow up, but want to verify that's the intent so we can create a separate issue to track that.
full page button position: I see Jack's note with the buttons more fixed to the bottom, but in my view they're more like the
master
version just below the description. Is there a certain condition where they change?
requested review from @slashmanov
added pipeline:mr-approved label
added pipelinetier-2 label and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 7efbc3e7expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 129 | 0 | 22 | 0 | 151 | ✅ | | Plan | 76 | 0 | 0 | 0 | 76 | ✅ | | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Package | 24 | 0 | 11 | 0 | 35 | ✅ | | Govern | 75 | 0 | 3 | 0 | 78 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 33 | 0 | 1 | 0 | 34 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 402 | 0 | 41 | 0 | 443 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 7efbc3e7expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 49 | 0 | 16 | 0 | 65 | ✅ | | Govern | 84 | 0 | 9 | 1 | 93 | ✅ | | Plan | 86 | 0 | 8 | 0 | 94 | ✅ | | Create | 140 | 0 | 20 | 0 | 160 | ✅ | | Secure | 2 | 0 | 5 | 0 | 7 | ✅ | | Package | 24 | 0 | 14 | 0 | 38 | ✅ | | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | | Data Stores | 33 | 0 | 10 | 0 | 43 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Fulfillment | 2 | 0 | 7 | 1 | 9 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Analytics | 2 | 0 | 0 | 1 | 2 | ✅ | | Ai-powered | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 436 | 0 | 119 | 3 | 555 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Stanislav Lashmanov
Looking at this shortly.
- Resolved by Stanislav Lashmanov
- Resolved by Stanislav Lashmanov
- Resolved by Stanislav Lashmanov
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-2 label
changed milestone to %17.7
added missed:17.6 label
started a merge train
mentioned in commit 499750c4
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label