Skip to content
Snippets Groups Projects

Fix Zoekt global code search- Backport

Merged Ravi Kumar requested to merge backport-17-4-fix-zoekt-global-search into 17-4-stable-ee

What does this MR do and why?

Backport for Fix Zoekt global code search (!165835 - merged)

Fix Zoekt global code search

There is no Code tab in search navigation now. There are no results with manual scope=blobs now.

This fix:

  • uses :zoekt_cross_namespace_search for navigation,
  • correctly overrides allowed scopes,
  • adds and updates tests.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • This MR has a severity label assigned (if applicable).
  • Set the milestone of the merge request to match the target backport branch version.
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the e2e:test-on-omnibus-ee job has either succeeded or been approved by a Software Engineer in Test.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Edited by Terri Chu

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • assigned to @rkumar555

  • Ravi Kumar changed target branch from master to 17-4-stable-ee

    changed target branch from master to 17-4-stable-ee

  • A deleted user added backend typebug labels

    added backend typebug labels

  • 1 Warning
    :warning: The e2e:test-on-omnibus-ee job needs to succeed or have approval from a Software Engineer in Test.
    Read the "QA e2e:test-on-omnibus-ee" section for more details.

    Reviewer roulette

    Category Reviewer Maintainer
    backend @tyleramos profile link current availability (UTC-4, 6 hours behind author) @DylanGriffith profile link current availability (UTC+11, 9 hours ahead of author)

    Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

    QA e2e:test-on-omnibus-ee

    @rkumar555, the e2e:test-on-omnibus job must complete before merging this merge request.*

    If there are failures on the e2e:test-on-omnibus pipeline, ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the #test-platform Slack channel.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    Edited by Ghost User
  • 🤖 GitLab Bot 🤖 resolved all threads

    resolved all threads

  • E2E Test Result Summary

    allure-report-publisher generated test report!

    e2e-test-on-omnibus: :x: test report for 3f7555be

    expand test summary
    +---------------------------------------------------------------------+
    |                           suites summary                            |
    +----------------+--------+--------+---------+-------+-------+--------+
    |                | passed | failed | skipped | flaky | total | result |
    +----------------+--------+--------+---------+-------+-------+--------+
    | Govern         | 108    | 0      | 5       | 0     | 113   | ✅     |
    | Create         | 547    | 0      | 72      | 0     | 619   | ✅     |
    | Plan           | 82     | 0      | 9       | 0     | 91    | ✅     |
    | Manage         | 25     | 2      | 18      | 6     | 45    | ❌     |
    | GitLab Metrics | 2      | 0      | 1       | 0     | 3     | ✅     |
    | Systems        | 7      | 0      | 0       | 1     | 7     | ✅     |
    | Configure      | 1      | 0      | 3       | 0     | 4     | ✅     |
    | Fulfillment    | 4      | 0      | 7       | 0     | 11    | ✅     |
    | Monitor        | 12     | 0      | 13      | 0     | 25    | ✅     |
    | Analytics      | 3      | 0      | 0       | 0     | 3     | ✅     |
    | Package        | 31     | 0      | 14      | 0     | 45    | ✅     |
    | Verify         | 51     | 0      | 15      | 0     | 66    | ✅     |
    | Data Stores    | 46     | 0      | 11      | 0     | 57    | ✅     |
    | Secure         | 4      | 0      | 2       | 0     | 6     | ✅     |
    | Release        | 5      | 0      | 1       | 0     | 6     | ✅     |
    | Ai-powered     | 0      | 0      | 2       | 0     | 2     | ➖     |
    | Growth         | 0      | 0      | 2       | 0     | 2     | ➖     |
    | ModelOps       | 0      | 0      | 1       | 0     | 1     | ➖     |
    +----------------+--------+--------+---------+-------+-------+--------+
    | Total          | 928    | 2      | 176     | 7     | 1106  | ❌     |
    +----------------+--------+--------+---------+-------+-------+--------+

    e2e-test-on-gdk: :white_check_mark: test report for 3f7555be

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Create      | 128    | 0      | 16      | 0     | 144   | ✅     |
    | Data Stores | 33     | 0      | 1       | 0     | 34    | ✅     |
    | Govern      | 72     | 0      | 0       | 0     | 72    | ✅     |
    | Verify      | 46     | 0      | 2       | 0     | 48    | ✅     |
    | Plan        | 74     | 0      | 1       | 0     | 75    | ✅     |
    | Fulfillment | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Package     | 20     | 0      | 12      | 0     | 32    | ✅     |
    | Secure      | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
    | Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Manage      | 1      | 0      | 1       | 0     | 2     | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 395    | 0      | 33      | 0     | 428   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+
    Edited by Ghost User
  • Ravi Kumar changed the description

    changed the description

  • Ravi Kumar changed milestone to %17.4

    changed milestone to %17.4

  • Ravi Kumar marked the checklist item This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch. as completed

    marked the checklist item This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch. as completed

  • Ravi Kumar marked the checklist item The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes). as completed

    marked the checklist item The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes). as completed

  • Ravi Kumar marked the checklist item Set the milestone of the merge request to match the target backport branch version. as completed

    marked the checklist item Set the milestone of the merge request to match the target backport branch version. as completed

  • @terrichu Could you please do the review for this backport MR?

  • Ravi Kumar requested review from @terrichu

    requested review from @terrichu

  • Terri Chu marked the checklist item This MR has a [severity label] assigned (if applicable). as completed

    marked the checklist item This MR has a [severity label] assigned (if applicable). as completed

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading