Skip to content

Check for software license compliance violations after license management report is generated.

mo khan requested to merge 13067-check-for-generated-report into master

What does this MR do?

This fixes a defect identified here. In this defect, we resolve the approval rules before the license management report is generated. This change waits for a license management report to be produced before checking for software license compliance violations. This ensures that when an MR is first submitted, the approval rule will default to requiring an approval until a valid license report is generated.

Screenshots

Before:

Screenshot_from_2019-09-16_14-15-18

After:

Screenshot_from_2019-09-16_14-23-15

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by mo khan

Merge request reports