Fix policy violations not being deleted properly

What does this MR do and why?

This change fixes a regression introduced in !164808 (merged) where unviolated approval rules would not have their corresponding violations deleted for unviolated policies.

This happened in two cases:

  • license scanning rules
  • previously existing vulnerability rules

This prevented the policy bot from being created on affected merge requests because the violations were seen as "pending evaluation".

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Martin Cavoj

Merge request reports

Loading