Protected packages: Return ServiceResponse for CreateConanPackageService
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you can request access to GitLab Duo.
What does this MR do and why?
- Returning a successful ServiceResponse as suggested in the GitLab best practice guidelines. see https://docs.gitlab.com/ee/development/reusing_abstractions.html#serviceresponse
- Exceptions raised in
Packages::Conan::CreatePackageServicehave been transformed to erroneous service response - This MR follows the same approach as in other MR, e.g. Protected packages: Return ServiceResponse for ... (!140778 - merged) and Protected packages: Return ServiceResponse in P... (!141386 - merged)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
MR Checklist (@gerardo-navarro)
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the javascript style guides -
Conforms to the database guides
Screenshots or screen recordings
Only backend changes. No frontend changes.
How to set up and validate locally
- Run the tests related to conan package creation to ensure that everything works fine
bundle exec rspec spec/services/packages/conan/create_package_service_spec.rb spec/requests/api/conan/v1/instance_packages_spec.rb spec/requests/api/conan/v1/project_packages_spec.rb
Related to #323975 (closed)
Edited by Gerardo Navarro