Skip to content

Calculate Composite Status in Ruby instead of using SQL

Kamil Trzciński requested to merge ruby-composite-status into master

What does this MR do?

This rewrites status_sql to be a Ruby method consuming :status and :allow_failure if present.

It seems to be significantly faster especially for ProcessPipelineService, as we do perform very cheap operation and have a very simple way to group statuses.

Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/65538 #15144 (closed)

Supersedes the gitlab-foss!31783 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports