Allow Instance Admin to always create projects
What does this MR do and why?
Bug:
Instance Admins who do not have any group/projects created by them cannot create groups/projects when allow_project_creation_for_guest_and_below setting is turned off.
Analysis:
When setting allow_project_creation_for_guest_and_below is turned off
-
allow_user_to_create_group_and_project? relies on
highest_role -
highest_roleis filled fromcurrent_highest_access_level -
current_highest_access_levelgets the maximum access_level a user has in thememberstable. - For Instance Admins who have not created any groups before turning the setting off(typical for new installations) ----> here is the bug
- they would not have any entry in the members table
-
highest_rolewould returnNO_ACCESSfor them - and allow_user_to_create_group_and_project? would return
false
- For Instance Admins who have created some groups before turning the setting off
- they would have any entry in the members table
- highest_role would return
OWNER -
allow_user_to_create_group_and_project? would return
true
Fix
Allow Instance Admin to always create projects
- Add spec for the same
Changelog: fixed
ref: #498054 (closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Edited by Suraj Tripathi