Skip to content

Use GlSearchBoxByType in project selector

What does this MR do?

It swaps the native search-input with GlSearchBoxByType in app/assets/javascripts/vue_shared/components/project_selector/project_selector.vue to bring it in line with the overall gitlab design direction.

Since GlSearchBoxByType manages autofocusing, this MR also removes the method (and any calls made to it) that was used to bring the focus to the search input once the modal opened.

https://gitlab.com/gitlab-org/gitlab-ee/issues/6953 (issue that aims to reuse the project-selector on a new dashboard and includes up-to-date designs).

More context: This MR originally started on CE and includes some notes that might be of interest - especially around switching the karma-tests to be asynchronous: gitlab-foss!32917 (comment 215350643)

Screenshots / Screencaptures

Before After
Screenshot_2019-09-11_Operations_Dashboard_1_ Screenshot_2019-09-11_Operations_Dashboard

project_selector

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by David Pisek

Merge request reports