Use GlSearchBoxByType in project selector
What does this MR do?
It swaps the native search-input with GlSearchBoxByType in app/assets/javascripts/vue_shared/components/project_selector/project_selector.vue to bring it in line with the overall gitlab design direction.
Since GlSearchBoxByType manages autofocusing, this MR also removes the method (and any calls made to it) that was used to bring the focus to the search input once the modal opened.
https://gitlab.com/gitlab-org/gitlab-ee/issues/6953 (issue that aims to reuse the project-selector on a new dashboard and includes up-to-date designs).
More context: This MR originally started on CE and includes some notes that might be of interest - especially around switching the karma-tests to be asynchronous: gitlab-foss!32917 (comment 215350643)
Screenshots / Screencaptures
| Before | After |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios. -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team