Replace newDateAsLocaleTime with newDate
What does this MR do and why?
Replace newDateAsLocaleTime with newDate
newDateAsLocaleTime was first introduced to convert
yyyy-mm-dd
strings to dates to local time, but with imo a
slightly confusing name since if you're unfamiliar with dates you might think "what does locale time mean here?".
Recently, a new function newDate was introduced to wrap around
the new Date() constructor while fixing this yyyy-mm-dd
bug.
newDate is a much clearer name as it just creates a new date object
as expected without the historical yyyy-mm-dd
bug, so this commit
just replaces newDateAsLocaleTime with newDate since they do the same
thing and deletes newDateAsLocaleTime so we have one single utility function for creating a new date.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
How to set up and validate locally
Merge request reports
Activity
changed milestone to %17.5
assigned to @cngo
added pipelinetier-1 label
- A deleted user
added frontend label
1 Warning The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.1 Message CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Category Reviewer Maintainer frontend @obaiye
(UTC-4, 5 hours behind author)
@kpalchyk
(UTC+3, 2 hours ahead of author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 11906787 and fcc5f6e4
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.37 MB 4.37 MB - -0.0 % mainChunk 3.3 MB 3.3 MB - -0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Kos Palchyk
@kpalchyk Mind if we skip to maintainer review here since we're just replacing functions with no changes in logic? It's related to the bunch of date stuff I've been consolidating recently
requested review from @kpalchyk
added pipeline:mr-approved label
added pipelinetier-3 pipeline:run-e2e-omnibus-once labels and removed pipelinetier-1 label
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you set this MR to auto-merge, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for fcc5f6e4expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 124 | 0 | 18 | 0 | 142 | ✅ | | Package | 24 | 0 | 11 | 0 | 35 | ✅ | | Plan | 69 | 0 | 0 | 1 | 69 | ✅ | | Govern | 61 | 0 | 0 | 0 | 61 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Verify | 43 | 0 | 2 | 0 | 45 | ✅ | | Data Stores | 32 | 0 | 1 | 0 | 33 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 375 | 0 | 33 | 1 | 408 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-omnibus:
test report for fcc5f6e4expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Create | 408 | 0 | 60 | 0 | 468 | ✅ | | Plan | 83 | 0 | 8 | 0 | 91 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 491 | 0 | 68 | 0 | 559 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
removed pipeline:run-e2e-omnibus-once label
started a merge train
mentioned in commit 4061f506
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label