Skip to content

Refactor RedisCacheStore patch to pipeline in redis-cluster-client

Sylvester Chin requested to merge sc1-simplify-rediscachestore-patch into master

What does this MR do and why?

Refactor RedisCacheStore patch to pipeline in redis-cluster-client

From redis-cluster-client v0.9.0, mget/del/mset commands are converted into pipelined get/del/set internally. This avoids us having to copy lines of code from the patch instead, calling super directly.

#487862

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Run BUNDLE_GEMFILE=Gemfile.next bin/rspec spec/lib/gitlab/patch/redis_cache_store_spec.rb to verify against Rails 7.1

Edited by Sylvester Chin

Merge request reports

Loading