Explicitly import spriteIcon helper (!16745) · Merge requests · GitLab.org / GitLab · GitLab

The 17.0 major release is coming on May 16, 2024! This version brings many exciting improvements to GitLab, but also removes some deprecated features. We are introducing three breaking change windows during which we expect breaking changes to be deployed to GitLab.com. You can read more about it on our blogpost . The first breaking change window begins 2024-04-22 09:00UTC and ends 2024-04-24 22:00UTC.

Illya Klymov requested to merge add-missing-sprite-icon into master Sep 15, 2019

What does this MR do?

Several files are using explicit gl.utils.spriteIcon instead of importing spriteIcon explicitly

This results in failing several tests when being run separately^

spec/javascripts/image_diff/helpers/badge_helper_spec.js
spec/javascripts/image_diff/helpers/comment_indicator_helper_spec.js

See #31702 (closed) for details

Does this MR meet the acceptance criteria?

Conformity

[-] Changelog entry for user-facing changes, or community contribution. Check the link for other scenarios.
[-] Documentation created/updated or follow-up review issue created
Code review guidelines
Merge request performance guidelines
Style guides
[-] Database guides
[-] Separation of EE specific content