Skip to content

Password modal to confirm two-factor actions

Eduardo Sanz García requested to merge eduardosanz/frontend-two-factor-actions into master

What does this MR do and why?

We created a new Vue component, TwoFactorAction, to replace ManageTwoFactorForm and to be used to destroy the one-time password authenticator.

The simpler TwoFactorAction component uses a better password field that toggle the visibility and takes less space because the password is inside the modal. By using the same modal in the whole page it makes the experience more consistent.

The new component is under the two_factor_actions feature flag.

On a follow-up, we will again re-use this new confirm modal to delete WebAuthn device.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

State Before After
Close modal image image
Open modal image image

How to set up and validate locally

  1. Enable the two_factor_actions (and optionally delete_otp_no_webauthn): /rails/features
  2. Go to /-/profile/two_factor_auth
  3. Create and destroy authenticators
Edited by Eduardo Sanz García

Merge request reports